feat(notifier,api): add plot configuration #1058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrMatsko
requested changes
Jul 19, 2024
cmd/api/config_test.go
Outdated
| @@ -30,6 +31,13 @@ func Test_apiConfig_getSettings(t *testing.T) { | |||
| apiConf := apiConfig{ | |||
| Listen: "0000", | |||
| EnableCORS: true, | |||
| PlotCfg: cmd.PlotConfig{ | |||
There was a problem hiding this comment.
Давай функцию замутим для создания PlotConfig в тестах?
There was a problem hiding this comment.
Сделал дефолтную переменную для тестов, чтобы переиспользовать
notifier/plotting_test.go
Outdated
| plotCfg := plotting.PlotConfig{ | ||
| Width: 800, | ||
| Height: 400, | ||
| } |
There was a problem hiding this comment.
А здесь не должна быть ещё инициализация YAxisSecondaryCfg?
There was a problem hiding this comment.
Вообще заполнится по умолчанию, то есть с EnablePrettyTicks=false, то добавил явную инициализацию и вынес в дефолтную переменную
AleksandrMatsko
previously approved these changes
Jul 19, 2024
|
/build |
|
Build and push Docker images with tag: feat-plot-configuration.2024-07-19.46592c6 |
1 similar comment
|
Build and push Docker images with tag: feat-plot-configuration.2024-07-19.46592c6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add plot configuration
Added graph customization for api and notifier to resize the graph without hardcoding and
EnablePrettyTickssetting