Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): add some default vals to TriggerModel #1047

Conversation

AleksandrMatsko
Copy link
Member

@AleksandrMatsko AleksandrMatsko commented Jul 5, 2024

Add default values to TTL and Schedule in TriggerModel

Lack of default values ​​may lead to incorrect behavior.

@AleksandrMatsko AleksandrMatsko changed the title refactor(api): add some default vals for TriggerModel refactor(api): add some default vals to TriggerModel Jul 5, 2024
@AleksandrMatsko AleksandrMatsko marked this pull request as ready for review July 5, 2024 10:17
@AleksandrMatsko AleksandrMatsko requested a review from a team as a code owner July 5, 2024 10:17
datatypes.go Show resolved Hide resolved
datatypes.go Outdated Show resolved Hide resolved
datatypes.go Outdated Show resolved Hide resolved
datatypes.go Outdated Show resolved Hide resolved
@AleksandrMatsko AleksandrMatsko requested a review from almostinf July 8, 2024 03:49
@AleksandrMatsko AleksandrMatsko requested a review from almostinf July 8, 2024 10:49
almostinf
almostinf previously approved these changes Jul 8, 2024
datatypes.go Outdated Show resolved Hide resolved
@almostinf
Copy link
Member

/build

@almostinf almostinf merged commit e719b3f into moira-alert:master Jul 9, 2024
6 checks passed
Copy link

github-actions bot commented Jul 9, 2024

Build and push Docker images with tag: 2024-07-09.e719b3f

1 similar comment
Copy link

github-actions bot commented Jul 9, 2024

Build and push Docker images with tag: 2024-07-09.e719b3f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants