fix(senders): fix workers lock key in discord and telegram #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build |
|
/build |
Tetrergeru
reviewed
May 22, 2024
senders/discord/init.go
Outdated
| discordLockTTL = 30 * time.Second | ||
| workerName = "DiscordBot" | ||
| messenger = "discord" | ||
| discordLockKey = "moira-discord-users:moira-bot-host:" |
There was a problem hiding this comment.
Мб так? Или у нас есть какая-то конвенция именования таких префиксов?
Suggested change
| discordLockKey = "moira-discord-users:moira-bot-host:" | |
| discordLockPrefix = "moira-discord-users:moira-bot-host:" |
Tetrergeru
reviewed
May 22, 2024
senders/discord/init.go
Outdated
| workerAction, | ||
| ).Run(nil) | ||
| } | ||
|
|
||
| func discordLock(name string) string { |
There was a problem hiding this comment.
Тогда тут можно будет так
Suggested change
| func discordLock(name string) string { | |
| func discordLockKey(name string) string { |
Tetrergeru
reviewed
May 22, 2024
senders/telegram/init.go
Outdated
| messenger = "telegram" | ||
| telegramLockTTL = 30 * time.Second | ||
| hidden = "[DATA DELETED]" | ||
| telegramLockKey = "moira-telegram-users:moira-bot-host:" |
Tetrergeru
approved these changes
May 22, 2024
kissken
approved these changes
May 22, 2024
|
Build and push Docker images with tag: 2024-05-22.6866623 |
2 similar comments
|
Build and push Docker images with tag: 2024-05-22.6866623 |
|
Build and push Docker images with tag: 2024-05-22.6866623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to make multiple telegram and discord senders
Fixed a bug with the same lock in telegram and discord senders when creating multiple senders