Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): limit handlers to admins only #1001

Merged
merged 8 commits into from
Mar 27, 2024

Conversation

Tetrergeru
Copy link
Member

@Tetrergeru Tetrergeru commented Mar 20, 2024

Limit handlers GET: /api/contact, /api/tag/stats, /api/trigger, /api/trigger/unused, DELETE api/event/all, /api/tag/{tag} access, now only admins can use them

Add field to /api/user/settings to indicate whether current user has admin rights

@Tetrergeru Tetrergeru requested a review from a team as a code owner March 20, 2024 15:31
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 67.70%. Comparing base (f1e51ba) to head (0c11cd7).

❗ Current head 0c11cd7 differs from pull request most recent head 9641606. Consider uploading reports for the commit 9641606 to get more accurate results

Files Patch % Lines
api/dto/user.go 0.00% 6 Missing ⚠️
api/handler/user.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
- Coverage   67.72%   67.70%   -0.03%     
==========================================
  Files         208      208              
  Lines       11949    11961      +12     
==========================================
+ Hits         8093     8098       +5     
- Misses       3358     3365       +7     
  Partials      498      498              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tetrergeru
Copy link
Member Author

/build

almostinf
almostinf previously approved these changes Mar 26, 2024
notifier/registrator.go Outdated Show resolved Hide resolved
almostinf
almostinf previously approved these changes Mar 26, 2024
@Tetrergeru
Copy link
Member Author

/build

1 similar comment
@Tetrergeru
Copy link
Member Author

/build

@Tetrergeru Tetrergeru merged commit 32a5011 into master Mar 27, 2024
7 checks passed
@Tetrergeru Tetrergeru deleted the feature/limit-handlers-to-admins-only branch March 27, 2024 08:52
Copy link

Build and push Docker images with tag: 2024-03-27.32a5011

1 similar comment
Copy link

Build and push Docker images with tag: 2024-03-27.32a5011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants