-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version update #179
Comments
You're welcome to add comments to the end of the issue you previously created asking for a new version to be released. Unless there is a breaking bug, which I don't consider the previous issue to be, I generally try to wait a while between releases so as not to annoy users of the package. I'll wait a bit longer to see if anything else comes in, and if not, I'll make a release. |
I consider to be a breaking change since a) it breaks tests (and thus assumptions about how the project works) and b) it takes information away from the user about how to fix the problem. I completely understand that you need to release when it is convenient for you, but I can't agree to the assertion that the change was not breaking. |
It doesn't break prawn-svg tests, and the message of an exception is not what I consider part of the contract a library gives to its users. It's less useful without it there, for sure, and that's why I made the change to put it back in, but that doesn't make it breaking in my eyes. Understood if you want to hold off until the next version is released. |
(I'm thinking a couple of days here, not a long time.) |
We can agree to disagree. I've voiced my concern. I don't expect you to change your mind. It's just where I stand on the issue and I needed to communicate that. |
Sorry to create an issue for this but I wanted to ask if it would be possible to release a minor version for fb8ae2c? asciidoctor/asciidoctor-pdf#2553 depends on the fix of this issue. Thank you.
The text was updated successfully, but these errors were encountered: