Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernjs: doesn't work with latest version v2.60.3 because of dev/peer dependencies #3293

Open
5 tasks done
GiancarlosIO opened this issue Nov 28, 2024 · 3 comments
Open
5 tasks done

Comments

@GiancarlosIO
Copy link

Describe the bug

When upgrading modern-js packages to latest version the modernjs process end up giving us weird errors (like it doesn't find the .env file). After testing, we found that this is because module-federation depends on 2.60.6

Notice that modern-js packages are not in peer dependencies.

image

Would be good to add the modernjs packages as peer dependencies and let the consumer use the correct range version.

Thanks!

Reproduction

Used Package Manager

pnpm

System Info

System:
    OS: macOS 15.0.1
    CPU: (8) arm64 Apple M1
    Memory: 73.98 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.13.1 - ~/.nvm/versions/node/v20.13.1/bin/node
    Yarn: 1.22.22 - ~/.nvm/versions/node/v20.13.1/bin/yarn
    npm: 10.5.2 - ~/.nvm/versions/node/v20.13.1/bin/npm
    pnpm: 9.12.0 - ~/.nvm/versions/node/v20.13.1/bin/pnpm
  Browsers:
    Brave Browser: 127.1.68.134
    Chrome: 131.0.6778.86
    Safari: 18.0.1

Validations

@ScriptedAlchemy
Copy link
Member

@GiancarlosIO do you have a repo we can look at

@2heal1
Copy link
Member

2heal1 commented Dec 13, 2024

Can you provide the reproduce repo ? Because the devDeps only related with types , i want to know which package cause this

@ScriptedAlchemy
Copy link
Member

@GiancarlosIO dev deps should not install on your box, only on ours.
Can you supply repo? the packages we have in dependencies have no weird interdependences that would load another version of modernjs in to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants