Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify why the update command fails on non git installs #3357

Open
2 tasks
sebkuip opened this issue Jan 16, 2025 · 1 comment
Open
2 tasks

Clarify why the update command fails on non git installs #3357

sebkuip opened this issue Jan 16, 2025 · 1 comment
Labels
code improvement feature request priority: low Something that's not on top of the list. You are free to submit a pull request though

Comments

@sebkuip
Copy link
Member

sebkuip commented Jan 16, 2025

Is your feature request related to a problem? Please elaborate.

When a user runs the ?update command, the bot will run git pull and then resetart itself. This is nice unless the bot isn't installed by git, which a lot of bots are not. The bot just spits out the raw error of not finding a .git folder which is confusing to most user.

Describe the solution you'd like

I would suggest that the ?update command first checks the presence of a .git folder (and anything else required for update to work) before starting. If this isn't found, the bot should spit out a clear message to the user instructing that their hosting platform does not support automatic updates, and instructions on how to manually update.

Does your solution involve any of the following?

  • Logviewer
  • New config option

Describe alternatives you've considered

N/A

Who will this benefit?

This will mostly benefit users that are less known with git and programming as they will get more clear errors and instructions on what to do. It will also benefit support staff as they have to explain this less.

Additional Information

No response

@sebkuip sebkuip added code improvement feature request priority: low Something that's not on top of the list. You are free to submit a pull request though labels Jan 16, 2025
@martinbndr
Copy link
Contributor

martinbndr commented Jan 16, 2025

Im thinking how the message could be written that the user gets when ther´s no git repo
Thoulgt of this embed:

embed = discord.Embed(
    title="Update Command Unavailable",
    description="The bot cannot be updated due to not being installed via a git."
                        "You need to manually update the bot according to your hosting method.",
    color=discord.Color.red()
    )

Or any other suggestions?
Will open a pr once I have the changes ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvement feature request priority: low Something that's not on top of the list. You are free to submit a pull request though
Projects
None yet
Development

No branches or pull requests

2 participants