Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GitLab.com #14

Closed
ImDreamerDev opened this issue Feb 9, 2019 · 12 comments
Closed

Support GitLab.com #14

ImDreamerDev opened this issue Feb 9, 2019 · 12 comments
Assignees
@mob-sakai
Labels
enhancement New feature or request released on @preview released
Milestone
0.6.0

Comments

@ImDreamerDev
Copy link

Love the work you are doing, keep it up 👍
It is possible to add support for GitLab, both private and public repos, that would be cool?
@mob-sakai mob-sakai self-assigned this Feb 9, 2019
@mob-sakai mob-sakai added the enhancement New feature or request label Feb 9, 2019
@mob-sakai
Copy link
Owner

Supporting GitLab is an easy task. :)
I will research about support of private repository later.
I think it requires api access token or username/password.

@ImDreamerDev
Copy link
Author

Sounds good, thanks for the quick reply, good luck :)

@mob-sakai
Copy link
Owner

Unfortunately, gitlab api requests private access token...
(GitHub and Bitbucket apis don't request)

I am looking for another way to get the names of all the branches/tags.

  • libgit2sharp
  • git on command line

@mob-sakai
Copy link
Owner

UPM requests 'executable git' to install a package with git.
If git is not installed, the following error message appears.

An error occurred while resolving packages:
  Project has invalid dependencies:
    **********(package name): No 'git' executable was found. Please install Git on your system and restart Unity

A re-import of the project may be required to fix the issue or a manual modification of **********(project path)/Packages/manifest.json file.

@buihuuloc
Copy link

Unfortunately, gitlab api requests private access token...

Can we config the private access token somewhere in the editor or in a config file?

@mob-sakai
Copy link
Owner

mob-sakai commented Feb 11, 2019 •
edited
Loading

Hi @buihuuloc
The problem here is that private access token is also required for the public repository on GitLab...
It is inconvenient if you do not have a GitLab account.

Fortunately, we can get all branch/tag names by running git ls - remote repo_url on the command line. :)

@mob-sakai mob-sakai mentioned this issue Feb 11, 2019
Closed
@mob-sakai mob-sakai changed the title Support for gitlab Support GitLab.com Feb 12, 2019
mob-sakai added a commit that referenced this issue Feb 12, 2019
@mob-sakai
close #14; Support GitLab.com
d3752f2
@mob-sakai mob-sakai added this to the 0.6.0 milestone Feb 12, 2019
mob-sakai added a commit that referenced this issue Feb 12, 2019
@mob-sakai
close #14; Support GitLab.com
1b8410d
@buihuuloc
Copy link

Is the support custom domain for gitlab?
I have my own in-house gitlab website.

@mob-sakai
Copy link
Owner

@buihuuloc
I don't have own GitLab server, so I can not test it right away...
How does UpmGitExtension work on GitLab server?

  • Document links are incorrect
  • Logo is incorrect
  • Repo url is incorrect
  • Uploading the package version is not available

@mob-sakai
Copy link
Owner

@Lasser01
About private repository >>> #15

@mob-sakai
Copy link
Owner

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mob-sakai pushed a commit that referenced this issue Nov 21, 2019
@semantic-release-bot
1.0.0-preview.1
33d9311 
    - dlls
- fix: Fix executor
- fix: Fix git button uss for 2019.2 or later
- fix: fix Expose
- fix: Omit generics feature in expose for .net 3.5
- Support for 2019.1.9

Support for 2019.1.9
- docs: Update readme
- fix: Support recomended version on Unity 2019.3
- fix: Suppress debug log
- feat(Compiler): Add deterministic mode
- fix: Fix error for Unity 2018
- style: Tab to space
- feat(Compiler): Optimize compiler
- fix: Fix git button border
- style: Remove unused assets

unused
- feat: Support 2019.3 (#50)

...

..
- chore: Disable auto compile
- fix: Fix get-refs on Windows
- fix: Fix reload bug on update package
- fix: Fix reload bug
- chore: Add debug codes
- chore: Remove unused assets
- fix: Update compiler version
- chore: Update release action
- chore: Remove unused assets
- fix: Fix commands path
- update compiler
- fix: get-refs script path error on windows
- chore: asmdef for develop
- fix: Fix install problem
- refactor: Remove unused code
- feat: Add internal accessible compiler
- feat: Add InternalAccessableCompiler
- chore: ignore compiler
- refactor: Change commands path
- refactor: asmdef settings
- Feat: Filter installable branches and tags (#48, #61, #62)
- refactor: Change develop symbol
- refactor: Rename assemblies

asem
- fix: Fix git script path
- fix: Fix bridge dll import settings
- refactor: Change directory for internal bridge
- test: Disable test
- refactor: Refactor utils class
- feat: Remove document actions class
- refactor: Refactor internal bridge
- feat: Use dll to internal bridging

To avoid assembly name conflict.
- feat: Simply install window
- chore: Ignore vscode settings
- feat: Internal bridging
- feat: Use internal access bridging instead of reflection (#58) (#60)

To access to internal member in PackageManager.UI assembly
- revert: Disable tag filter
- fix: Change Markdig dll file name to avoid to conflict (#64)
- Merge pull request #57 from mob-sakai/develop

New Release
- fix: Replace version in package.json on release (#56)
- doc: Update readme
- Merge pull request #55 from mob-sakai/develop

New Release
- doc: Update readme
- fix: Overwrite manifest.json on install package via install window
- fix: Support Unity 2019.1 or later (#54)
- Merge pull request #53 from mob-sakai/develop

New Release
- chore: Fix github action
- chore: Move templates and funding
- chore: Update readme
- chore: Update release protocol
- chore: Update package.json and lock
- chore: Remove unnecessary files
- chore: Format and add release protocol in package.json
- chore: Add ignore for npm
- chore: Add release work flow for GitHub Actions
- doc: Update funding
- doc: Add issue templates
- refactor: Change package directory name
- feat: Support git dependency in the package #35
- feat: Tag filtering #45
- release 0.9.1
- update documents for 0.9.1
- Update release script
- release 0.9.0
- Add GitHub template
- update documents for 0.9.0
- Update release script
- fix: Fix for private repo
- fix: Remove uss property
- Add menu item to clear kvs for debugging
- Refactor: Change package src directory
- Add limited debug class to suppress logging
- Refactor: Rename class
- fix: An error occurs during initialization
- Update readme
- Remove an unused package
- Update release script
- Refactor
- fix for Unity 2019.1
- Update readme
- close #37; On Unity 2019.1 or later, show all tags/branches as versions
close #26; Updatable indicator
- close #39; Use preferentially raw.githack.com to download package.json
- Refactor
- Create document actions element
- Cache result of git command #38
- Add git-button to open install package window
- close #21; Improve add package window
- Remove test project
- Move to Packages directory
- release 0.8.3
- update documents for 0.8.3
- fix #34; Error on 'git ls-remote' for private repos accessed via SSH
- Merge pull request #32 from jeffcampbellmakesgames/fix/repository_spelling_typo

Fixed spelling typo
- Fixed spelling typo

* Fixed spelling typo for repository
- release 0.8.2
- update documents for 0.8.2
- fix #31; An error occurs when installing 0.7.0+
- release 0.8.1
- update documents for 0.8.1
- Update readme
- close #30; Support .Net 3.5 scripting runtime version
- fix #27; Unit Tests don't pass
- Update readme
- release 0.8.0
- update documents for 0.8.0
- close #24; Focus to url text field when Add Package Window opened
- fix #23; Unable to add more than one package from url on Windows
- fix #22; Unable to add package from url on Windows
- close #20; View offline documents
- release 0.7.0
- update documents for 0.7.0
- Update readme
- Support Unity 2019.1
- close #8; Add package from url
- Refactor uss
- Move assets
- Update documents
- release 0.6.1
- update documents for 0.6.1
- Update readme
- release 0.6.0
- update documents for 0.6.0
- close #14; Support GitLab.com
- add test packages
- fix #16; Bitbucket document links are dead
- Refactor
- close #17; Use system git instead of WebRequest to get branch/tag names
- release 0.5.0
- update documents for 0.5.0
- Update documents
- close #7; Support Bitbucket.org
- release 0.4.0
- update documents for 0.4.0
- Update release protocol
- Remove debug log for test
- Add documents for UnityList
- Delete documents
- fix #13; Broken on 2019.1's new PM
- Remove tests in package
- Update readme
- release 0.3.1
- update change log
- Fix readme
- release 0.3.0
- update change log
- Update readme
- Demo
- Update tests
- close #9; Update package button
- release 0.2.0
- update change log
- Update test
- Update readme
- Show update/remove button
- release 0.1.2
- update change log
- Update release script
- Fix initialize
- release 0.1.1
- update change log
- Fix readme
- Fix package name
- Add test project
- release 0.1.0
- update change log
- Update readme
- Change package name
- Update release script
- Add release script
- Change directory name
- Add ignore for package
- Add symbolic link
- Add tests
- Override link to document URL and support GitHub
- Add project
- initial commit
@mob-sakai
Copy link
Owner

🎉 This issue has been resolved in version 1.0.0-preview.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mob-sakai pushed a commit that referenced this issue Nov 24, 2019
@semantic-release-bot
1.0.0
e833826 
    - docs: Update docs
- chore: Add ignore directory for test
- fix: Disable validate reference for 2018.3
- chore: Update dll
- fix: Add null check for 2019.3
- fix: Update dlls
- fix: develop flow
- chore: Add dll generator
- Fix: Update dlls
- fix: Fix member name of PackageInfo
- fix: Fix compiler
- fix: Fix dll for 2019.3
- chore: Add ignores for develop
- dlls
- fix: Fix executor
- fix: Fix git button uss for 2019.2 or later
- fix: fix Expose
- fix: Omit generics feature in expose for .net 3.5
- Support for 2019.1.9

Support for 2019.1.9
- docs: Update readme
- fix: Support recomended version on Unity 2019.3
- fix: Suppress debug log
- feat(Compiler): Add deterministic mode
- fix: Fix error for Unity 2018
- style: Tab to space
- feat(Compiler): Optimize compiler
- fix: Fix git button border
- style: Remove unused assets

unused
- feat: Support 2019.3 (#50)

...

..
- chore: Disable auto compile
- fix: Fix get-refs on Windows
- fix: Fix reload bug on update package
- fix: Fix reload bug
- chore: Add debug codes
- chore: Remove unused assets
- fix: Update compiler version
- chore: Update release action
- chore: Remove unused assets
- fix: Fix commands path
- update compiler
- fix: get-refs script path error on windows
- chore: asmdef for develop
- fix: Fix install problem
- refactor: Remove unused code
- feat: Add internal accessible compiler
- feat: Add InternalAccessableCompiler
- chore: ignore compiler
- refactor: Change commands path
- refactor: asmdef settings
- Feat: Filter installable branches and tags (#48, #61, #62)
- refactor: Change develop symbol
- refactor: Rename assemblies

asem
- fix: Fix git script path
- fix: Fix bridge dll import settings
- refactor: Change directory for internal bridge
- test: Disable test
- refactor: Refactor utils class
- feat: Remove document actions class
- refactor: Refactor internal bridge
- feat: Use dll to internal bridging

To avoid assembly name conflict.
- feat: Simply install window
- chore: Ignore vscode settings
- feat: Internal bridging
- feat: Use internal access bridging instead of reflection (#58) (#60)

To access to internal member in PackageManager.UI assembly
- revert: Disable tag filter
- fix: Change Markdig dll file name to avoid to conflict (#64)
- Merge pull request #57 from mob-sakai/develop

New Release
- fix: Replace version in package.json on release (#56)
- doc: Update readme
- Merge pull request #55 from mob-sakai/develop

New Release
- doc: Update readme
- fix: Overwrite manifest.json on install package via install window
- fix: Support Unity 2019.1 or later (#54)
- Merge pull request #53 from mob-sakai/develop

New Release
- chore: Fix github action
- chore: Move templates and funding
- chore: Update readme
- chore: Update release protocol
- chore: Update package.json and lock
- chore: Remove unnecessary files
- chore: Format and add release protocol in package.json
- chore: Add ignore for npm
- chore: Add release work flow for GitHub Actions
- doc: Update funding
- doc: Add issue templates
- refactor: Change package directory name
- feat: Support git dependency in the package #35
- feat: Tag filtering #45
- release 0.9.1
- update documents for 0.9.1
- Update release script
- release 0.9.0
- Add GitHub template
- update documents for 0.9.0
- Update release script
- fix: Fix for private repo
- fix: Remove uss property
- Add menu item to clear kvs for debugging
- Refactor: Change package src directory
- Add limited debug class to suppress logging
- Refactor: Rename class
- fix: An error occurs during initialization
- Update readme
- Remove an unused package
- Update release script
- Refactor
- fix for Unity 2019.1
- Update readme
- close #37; On Unity 2019.1 or later, show all tags/branches as versions
close #26; Updatable indicator
- close #39; Use preferentially raw.githack.com to download package.json
- Refactor
- Create document actions element
- Cache result of git command #38
- Add git-button to open install package window
- close #21; Improve add package window
- Remove test project
- Move to Packages directory
- release 0.8.3
- update documents for 0.8.3
- fix #34; Error on 'git ls-remote' for private repos accessed via SSH
- Merge pull request #32 from jeffcampbellmakesgames/fix/repository_spelling_typo

Fixed spelling typo
- Fixed spelling typo

* Fixed spelling typo for repository
- release 0.8.2
- update documents for 0.8.2
- fix #31; An error occurs when installing 0.7.0+
- release 0.8.1
- update documents for 0.8.1
- Update readme
- close #30; Support .Net 3.5 scripting runtime version
- fix #27; Unit Tests don't pass
- Update readme
- release 0.8.0
- update documents for 0.8.0
- close #24; Focus to url text field when Add Package Window opened
- fix #23; Unable to add more than one package from url on Windows
- fix #22; Unable to add package from url on Windows
- close #20; View offline documents
- release 0.7.0
- update documents for 0.7.0
- Update readme
- Support Unity 2019.1
- close #8; Add package from url
- Refactor uss
- Move assets
- Update documents
- release 0.6.1
- update documents for 0.6.1
- Update readme
- release 0.6.0
- update documents for 0.6.0
- close #14; Support GitLab.com
- add test packages
- fix #16; Bitbucket document links are dead
- Refactor
- close #17; Use system git instead of WebRequest to get branch/tag names
- release 0.5.0
- update documents for 0.5.0
- Update documents
- close #7; Support Bitbucket.org
- release 0.4.0
- update documents for 0.4.0
- Update release protocol
- Remove debug log for test
- Add documents for UnityList
- Delete documents
- fix #13; Broken on 2019.1's new PM
- Remove tests in package
- Update readme
- release 0.3.1
- update change log
- Fix readme
- release 0.3.0
- update change log
- Update readme
- Demo
- Update tests
- close #9; Update package button
- release 0.2.0
- update change log
- Update test
- Update readme
- Show update/remove button
- release 0.1.2
- update change log
- Update release script
- Fix initialize
- release 0.1.1
- update change log
- Fix readme
- Fix package name
- Add test project
- release 0.1.0
- update change log
- Update readme
- Change package name
- Update release script
- Add release script
- Change directory name
- Add ignore for package
- Add symbolic link
- Add tests
- Override link to document URL and support GitHub
- Add project
- initial commit
@mob-sakai
Copy link
Owner

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mob-sakai mob-sakai

Labels
enhancement New feature or request released on @preview released
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
3 participants
@buihuuloc @ImDreamerDev @mob-sakai