Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GetPropertyInfoListAsync is using incorrect deserializer #100

Open
agolotin opened this issue Jul 8, 2021 · 0 comments
Open

[Bug] GetPropertyInfoListAsync is using incorrect deserializer #100

agolotin opened this issue Jul 8, 2021 · 0 comments

Comments

@agolotin
Copy link

agolotin commented Jul 8, 2021

Calling Get-SFSubNameInfoList does not work. After digging into the code I attempted to repro in powershell

Connect-SFCluster ...
$sfHttpClient = $ExecutionContext.SessionState.PSVariable.Get("SFHttpClusterConnection").Value
$sfHttpClient.Properties.GetSubNameInfoListAsync("<valid_prop_name>", $false, [Microsoft.ServiceFabric.Common.ContinuationToken]::Default, 15).GetAwaiter().GetResult()

Inspected the http trace via fiddler - the request was successfully going through. Finally noticed GetSubNameInfoListAsync is using PropertyInfoConverter.Deserialize for deserialization which is not correct. That serializer does not handle response from $/GetSubNames.

return this.httpClient.SendAsyncGetResponseAsPagedData(RequestFunc, url, PropertyInfoConverter.Deserialize, requestId, cancellationToken);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant