Issue with Map api path with double slash

[npalla]

We are trying to move from proxy-kit to reverse-proxy and and working fine, But we have issue with double slashes. If the api path has double slashes like http://dev.localdev.tcpci.com/app/managepermit//extapi/system/setting, the request is rejected as 404 Not Found inside Linux Container. If I need to update/cleanup the path to remove double slash, what's the best place to do the same. Any suggestions?

Thanks

[Tratcher]

That value is coming from the client and is not an assembly mistake by the proxy, right?

The fixup is a simple string replace, but deciding when to do it is interesting. From your prior post, it looks like you're using IHttpProxy directly? #736. In that case you'd want to fix the path either before calling ProxyAsync or inside the request transform callback. Here's what a request transform would look like:

reverse-proxy/samples/ReverseProxy.Direct.Sample/Startup.cs

Lines 64 to 72 in cd117da

	private class CustomTransformer : HttpTransformer
	{
	public override async Task TransformRequestAsync(HttpContext httpContext, HttpRequestMessage proxyRequest, string destinationPrefix)
	{
	// Copy headers normally and then remove the host.
	// Use the destination host from proxyRequest.RequestUri instead.
	await base.TransformRequestAsync(httpContext, proxyRequest, destinationPrefix);
	proxyRequest.Headers.Host = null;
	}

Here's how the request uri gets built (with some allocation improvements that just got made). You can modify the path while assembling the proxyRequest.RequestUri in your own transform.
https://github.com/microsoft/reverse-proxy/pull/740/files

[npalla]

if we use Map("/{**catch-all}") with a check to see if my route has "egapi" it works fine. But I believe we hit the reverse proxy code for every api request from UI. I am just concerned if that has any performance hit for heavy traffic.

[npalla]

[Tratcher]

If it's messing with the proxy routing then you can fix the path before routing happens.

            app.Use((context, next) =>
            {
                var path = context.Request.Path.Value;
                path = path.Replace("//", "/");
                context.Request.Path = new PathString(path);

                return next();
            });
            app.UseRouting();
            app.UseAuthorization();
            app.UseEndpoints(endpoints =>
            {
// ...

[npalla]

It's not the proxy routing that throwing 404, it's the UI request. Is there any way we can do the same fix before the Request starting ...

[Tratcher]

Those logs look like you've applied the above workaround? Where? Doing it at the top of Startup.Configure should have been early enough.