Add degradation metric computation implementation #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a baisc implementation for computing degradataion metric as described in the paper. The implementation, along with the helper class, can compute degradation from metric points provided in input, where each metric point is annotated with the operator (e.g. phase) it is associated with and the type of metric. Additionally, tests have been created to ensure the functionality is working as expected. The project structure has also been updated to accommodate these new additions.
jcamachor
reviewed
Aug 3, 2023
| version='0.1', | ||
| packages=find_packages(), | ||
| install_requires=[ | ||
| 'pandas>=1.5.3', |
There was a problem hiding this comment.
I'm not that familiar with Python conventions, but the project contains a list of required packages that were added by @poojanilangekar :
https://github.com/microsoft/lst-bench/blob/main/metrics/notebooks/requirements.txt
Shouldn't this list match that one (and have a single source of truth rather than two as well)?
| @@ -0,0 +1,83 @@ | |||
| """ | |||
There was a problem hiding this comment.
Shouldn't this file be under metrics/utils/ to match the existing folder structure of the Python project? It seems that all the other metrics (cluster, storage) where committed there. If we want to have a folder per metric type, maybe the others should be moved into their own folder (cc @anjagruenheid )? WDYT?
jcamachor
force-pushed
the
main
branch
6 times, most recently
from
44a31f1 to
13a6b2c
Compare
jcamachor
force-pushed
the
main
branch
2 times, most recently
from
868d4f8 to
ff310c5
Compare
jcamachor
force-pushed
the
main
branch
3 times, most recently
from
4def705 to
7876be3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a basic implementation for computing degradation metric as described in the paper. The implementation, along with the helper class, can compute degradation from metric points provided in input, where each metric point is annotated with the operator (e.g. phase) it is associated with and the type of metric.
Additionally, tests have been created to ensure the functionality is working as expected. The project structure has also been updated to accommodate these new additions.
The change does not trigger build testing yet.
Fix #90