From 5aecf54673d37e852d241beac8b3c7ec392071ab Mon Sep 17 00:00:00 2001 From: Saanica Ghate Date: Thu, 18 Apr 2024 16:47:51 +0530 Subject: [PATCH 01/16] color contrast fix --- src/DetailsView/components/base-left-nav.scss | 11 +++++++ .../left-nav/common-left-nav-link.scss | 13 ++++++++ .../left-nav/details-view-left-nav.scss | 33 +++++++++++++++++-- .../components/left-nav/left-nav-icon.scss | 11 +++++++ 4 files changed, 66 insertions(+), 2 deletions(-) diff --git a/src/DetailsView/components/base-left-nav.scss b/src/DetailsView/components/base-left-nav.scss index 71eeb05af13..1a2ed4c3be9 100644 --- a/src/DetailsView/components/base-left-nav.scss +++ b/src/DetailsView/components/base-left-nav.scss @@ -23,6 +23,12 @@ a, button { background-color: $nav-link-selected !important; + + @media (forced-colors: active) { + forced-color-adjust: none; + + background-color: Highlight !important; + } } } @@ -36,6 +42,11 @@ a, button { background-color: $nav-link-hover; + + @media (forced-colors: active) { + forced-color-adjust: none; + border: 2px solid Highlight !important; + } } } } diff --git a/src/DetailsView/components/left-nav/common-left-nav-link.scss b/src/DetailsView/components/left-nav/common-left-nav-link.scss index 7e3b8cb4ee9..92c7662325b 100644 --- a/src/DetailsView/components/left-nav/common-left-nav-link.scss +++ b/src/DetailsView/components/left-nav/common-left-nav-link.scss @@ -17,6 +17,19 @@ color: $always-black; } + @media (forced-colors: active) { + :global(.is-selected) & { + forced-color-adjust: none; + color: HighlightText; + } + + :global(.ms-Nav-compositeLink):hover & { + forced-color-adjust: none; + color: HighlightText !important; + + } + } + .link-icon { font-size: 24px; } diff --git a/src/DetailsView/components/left-nav/details-view-left-nav.scss b/src/DetailsView/components/left-nav/details-view-left-nav.scss index 31b53da6182..1a4f9f11727 100644 --- a/src/DetailsView/components/left-nav/details-view-left-nav.scss +++ b/src/DetailsView/components/left-nav/details-view-left-nav.scss @@ -80,17 +80,46 @@ .ms-Button-label, .overview-percent { color: $highlighted-text; + + @media (forced-colors: active) { + forced-color-adjust: none; + color: HighlightText !important; + } } .left-nav-icon { color: $left-nav-icon; + + @media (forced-colors: active) { + forced-color-adjust: none; + color: HighlightText !important; + } } } a::after, button::after { - border-left: $pivot-item-left-border-width $pivot-item-border-style - $communication-primary; + border-left: $pivot-item-left-border-width $pivot-item-border-style $communication-primary; + } + } + } + + .ms-Nav-compositeLink:hover { + a, + button { + .ms-Button-label, + .overview-percent { + @media (forced-colors: active) { + forced-color-adjust: none; + color: HighlightText !important; + } + } + + .left-nav-icon { + @media (forced-colors: active) { + forced-color-adjust: none; + color: HighlightText !important; + } } } } diff --git a/src/DetailsView/components/left-nav/left-nav-icon.scss b/src/DetailsView/components/left-nav/left-nav-icon.scss index 37e8afa94e0..97b8da7b5e6 100644 --- a/src/DetailsView/components/left-nav/left-nav-icon.scss +++ b/src/DetailsView/components/left-nav/left-nav-icon.scss @@ -21,4 +21,15 @@ background: $index-circle-background; border-color: $neutral-0; } + + @media (forced-colors: active) { + li :global(.is-expanded) &, + :global(.ms-Nav-compositeLink):hover &, + :global(.ms-Nav-compositeLink.is-selected) & { + forced-color-adjust: none; + background-color: ButtonFace !important; + color: ButtonText !important; + border-color: ButtonText !important; + } + } } From bbd5c9c8cd8d562deffea925af6bf3b905034043 Mon Sep 17 00:00:00 2001 From: Saanica Ghate Date: Mon, 22 Apr 2024 11:31:06 +0530 Subject: [PATCH 02/16] color contrast and format fix --- src/DetailsView/components/base-left-nav.scss | 5 +++-- .../components/left-nav/common-left-nav-link.scss | 6 +++--- .../components/left-nav/details-view-left-nav.scss | 7 ++++--- src/DetailsView/components/left-nav/left-nav-icon.scss | 2 +- 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/DetailsView/components/base-left-nav.scss b/src/DetailsView/components/base-left-nav.scss index 1a2ed4c3be9..bf9aa2e01d0 100644 --- a/src/DetailsView/components/base-left-nav.scss +++ b/src/DetailsView/components/base-left-nav.scss @@ -26,7 +26,6 @@ @media (forced-colors: active) { forced-color-adjust: none; - background-color: Highlight !important; } } @@ -44,10 +43,12 @@ background-color: $nav-link-hover; @media (forced-colors: active) { - forced-color-adjust: none; border: 2px solid Highlight !important; } } } } + :global(ms-Nav-compositeLink):focus:hover { + color: inherit; + } } diff --git a/src/DetailsView/components/left-nav/common-left-nav-link.scss b/src/DetailsView/components/left-nav/common-left-nav-link.scss index 92c7662325b..172ce2fd9ef 100644 --- a/src/DetailsView/components/left-nav/common-left-nav-link.scss +++ b/src/DetailsView/components/left-nav/common-left-nav-link.scss @@ -24,9 +24,9 @@ } :global(.ms-Nav-compositeLink):hover & { - forced-color-adjust: none; - color: HighlightText !important; - + //forced-color-adjust: none; + + //color: inherit !important; } } diff --git a/src/DetailsView/components/left-nav/details-view-left-nav.scss b/src/DetailsView/components/left-nav/details-view-left-nav.scss index 1a4f9f11727..4148eeb6861 100644 --- a/src/DetailsView/components/left-nav/details-view-left-nav.scss +++ b/src/DetailsView/components/left-nav/details-view-left-nav.scss @@ -99,7 +99,8 @@ a::after, button::after { - border-left: $pivot-item-left-border-width $pivot-item-border-style $communication-primary; + border-left: $pivot-item-left-border-width $pivot-item-border-style + $communication-primary; } } } @@ -111,14 +112,14 @@ .overview-percent { @media (forced-colors: active) { forced-color-adjust: none; - color: HighlightText !important; + color: HighlightText !important; } } .left-nav-icon { @media (forced-colors: active) { forced-color-adjust: none; - color: HighlightText !important; + color: HighlightText !important; } } } diff --git a/src/DetailsView/components/left-nav/left-nav-icon.scss b/src/DetailsView/components/left-nav/left-nav-icon.scss index 97b8da7b5e6..cf6abb77075 100644 --- a/src/DetailsView/components/left-nav/left-nav-icon.scss +++ b/src/DetailsView/components/left-nav/left-nav-icon.scss @@ -28,7 +28,7 @@ :global(.ms-Nav-compositeLink.is-selected) & { forced-color-adjust: none; background-color: ButtonFace !important; - color: ButtonText !important; + color: ButtonText !important; border-color: ButtonText !important; } } From d775b5ead7247be6e4b92608629700f41936cc7c Mon Sep 17 00:00:00 2001 From: Saanica Ghate Date: Mon, 22 Apr 2024 12:42:57 +0530 Subject: [PATCH 03/16] color contrast and lint check fix --- src/DetailsView/components/base-left-nav.scss | 3 --- .../left-nav/common-left-nav-link.scss | 6 ------ .../left-nav/details-view-left-nav.scss | 21 +------------------ 3 files changed, 1 insertion(+), 29 deletions(-) diff --git a/src/DetailsView/components/base-left-nav.scss b/src/DetailsView/components/base-left-nav.scss index bf9aa2e01d0..b2254905012 100644 --- a/src/DetailsView/components/base-left-nav.scss +++ b/src/DetailsView/components/base-left-nav.scss @@ -48,7 +48,4 @@ } } } - :global(ms-Nav-compositeLink):focus:hover { - color: inherit; - } } diff --git a/src/DetailsView/components/left-nav/common-left-nav-link.scss b/src/DetailsView/components/left-nav/common-left-nav-link.scss index 172ce2fd9ef..f028d955a39 100644 --- a/src/DetailsView/components/left-nav/common-left-nav-link.scss +++ b/src/DetailsView/components/left-nav/common-left-nav-link.scss @@ -22,12 +22,6 @@ forced-color-adjust: none; color: HighlightText; } - - :global(.ms-Nav-compositeLink):hover & { - //forced-color-adjust: none; - - //color: inherit !important; - } } .link-icon { diff --git a/src/DetailsView/components/left-nav/details-view-left-nav.scss b/src/DetailsView/components/left-nav/details-view-left-nav.scss index 4148eeb6861..2a381586485 100644 --- a/src/DetailsView/components/left-nav/details-view-left-nav.scss +++ b/src/DetailsView/components/left-nav/details-view-left-nav.scss @@ -105,26 +105,7 @@ } } - .ms-Nav-compositeLink:hover { - a, - button { - .ms-Button-label, - .overview-percent { - @media (forced-colors: active) { - forced-color-adjust: none; - color: HighlightText !important; - } - } - - .left-nav-icon { - @media (forced-colors: active) { - forced-color-adjust: none; - color: HighlightText !important; - } - } - } - } - + .ms-Pivot-text { font-size: $font-size-s; } From 13162b2b1972d77838b801b21162a636978ad2c5 Mon Sep 17 00:00:00 2001 From: Saanica Ghate Date: Mon, 22 Apr 2024 12:49:36 +0530 Subject: [PATCH 04/16] format fix --- src/DetailsView/components/left-nav/details-view-left-nav.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/src/DetailsView/components/left-nav/details-view-left-nav.scss b/src/DetailsView/components/left-nav/details-view-left-nav.scss index 2a381586485..21bb8edd263 100644 --- a/src/DetailsView/components/left-nav/details-view-left-nav.scss +++ b/src/DetailsView/components/left-nav/details-view-left-nav.scss @@ -105,7 +105,6 @@ } } - .ms-Pivot-text { font-size: $font-size-s; } From 885907d207ea0d43121f02e21aa1fb8a0d03a839 Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Thu, 4 Jul 2024 13:02:04 +0530 Subject: [PATCH 05/16] wc issue fix --- src/DetailsView/components/base-left-nav.scss | 2 +- .../components/left-nav/common-left-nav-link.scss | 13 ++++++++++--- .../components/left-nav/details-view-left-nav.scss | 9 --------- 3 files changed, 11 insertions(+), 13 deletions(-) diff --git a/src/DetailsView/components/base-left-nav.scss b/src/DetailsView/components/base-left-nav.scss index b2254905012..bd220e18ec4 100644 --- a/src/DetailsView/components/base-left-nav.scss +++ b/src/DetailsView/components/base-left-nav.scss @@ -43,7 +43,7 @@ background-color: $nav-link-hover; @media (forced-colors: active) { - border: 2px solid Highlight !important; + background-color: Highlight !important; } } } diff --git a/src/DetailsView/components/left-nav/common-left-nav-link.scss b/src/DetailsView/components/left-nav/common-left-nav-link.scss index f028d955a39..3ad891a2cba 100644 --- a/src/DetailsView/components/left-nav/common-left-nav-link.scss +++ b/src/DetailsView/components/left-nav/common-left-nav-link.scss @@ -22,9 +22,16 @@ forced-color-adjust: none; color: HighlightText; } - } - .link-icon { - font-size: 24px; + :global(.ms-Nav-compositeLink):hover & { + forced-color-adjust: none; + color: HighlightText !important; + } + + + + .link-icon { + font-size: 24px; + } } } diff --git a/src/DetailsView/components/left-nav/details-view-left-nav.scss b/src/DetailsView/components/left-nav/details-view-left-nav.scss index 21bb8edd263..97c942ee29d 100644 --- a/src/DetailsView/components/left-nav/details-view-left-nav.scss +++ b/src/DetailsView/components/left-nav/details-view-left-nav.scss @@ -13,10 +13,6 @@ height: calc(100vh - (#{$details-view-header-bar-height})); :global { - .left-nav-icon { - color: $neutral-60; - } - .ms-Nav-groupContent { margin-bottom: 0; } @@ -48,7 +44,6 @@ } .overview-percent { - color: $neutral-55; line-height: 16px; font-size: 12px; } @@ -64,10 +59,6 @@ border-bottom: 0; } - .ms-Button-label { - color: $neutral-100; - } - &.is-selected { .ms-Button-label { color: $always-black; From e4f9f4cd978ede3f5ebc0ac00672d12dc353567c Mon Sep 17 00:00:00 2001 From: Saanica Ghate Date: Thu, 4 Jul 2024 16:50:06 +0530 Subject: [PATCH 06/16] Added underlines upon hover on links --- src/DetailsView/components/left-nav/common-left-nav-link.scss | 2 -- src/common/components/new-tab-link-with-tooltip.scss | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/DetailsView/components/left-nav/common-left-nav-link.scss b/src/DetailsView/components/left-nav/common-left-nav-link.scss index 3ad891a2cba..3b945d0ec79 100644 --- a/src/DetailsView/components/left-nav/common-left-nav-link.scss +++ b/src/DetailsView/components/left-nav/common-left-nav-link.scss @@ -28,8 +28,6 @@ color: HighlightText !important; } - - .link-icon { font-size: 24px; } diff --git a/src/common/components/new-tab-link-with-tooltip.scss b/src/common/components/new-tab-link-with-tooltip.scss index 3c13bd87883..2858434aebe 100644 --- a/src/common/components/new-tab-link-with-tooltip.scss +++ b/src/common/components/new-tab-link-with-tooltip.scss @@ -20,6 +20,6 @@ &:hover, &:active { - text-decoration: none !important; + text-decoration: underline !important; } } From e86db5b103dc492b810e078ed22d1fa382d105ea Mon Sep 17 00:00:00 2001 From: Saanica Ghate Date: Fri, 5 Jul 2024 17:12:36 +0530 Subject: [PATCH 07/16] added color change upon hover on link in high contrast mode --- src/common/components/new-tab-link-with-tooltip.scss | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/common/components/new-tab-link-with-tooltip.scss b/src/common/components/new-tab-link-with-tooltip.scss index 2858434aebe..d625fac76fa 100644 --- a/src/common/components/new-tab-link-with-tooltip.scss +++ b/src/common/components/new-tab-link-with-tooltip.scss @@ -23,3 +23,10 @@ text-decoration: underline !important; } } + +@media screen and (forced-colors: active) { + .insights-link:hover { + forced-color-adjust: none; + color: ButtonText !important; + } +} From 9db109009fbc0dc6929525d75a0a20549b8f6529 Mon Sep 17 00:00:00 2001 From: Saanica Ghate Date: Mon, 8 Jul 2024 17:46:41 +0530 Subject: [PATCH 08/16] underline and color change upon hover for icon and link --- .../components/requirement-context-section.scss | 4 +++- src/common/components/new-tab-link-with-tooltip.scss | 12 +++++++++++- src/common/components/new-tab-link-with-tooltip.tsx | 9 +++++++-- .../content/__snapshots__/content-link.test.tsx.snap | 4 ++++ src/views/content/content-link.tsx | 2 ++ 5 files changed, 27 insertions(+), 4 deletions(-) diff --git a/src/DetailsView/components/requirement-context-section.scss b/src/DetailsView/components/requirement-context-section.scss index 1c664670244..74a8af60ba0 100644 --- a/src/DetailsView/components/requirement-context-section.scss +++ b/src/DetailsView/components/requirement-context-section.scss @@ -46,13 +46,15 @@ &:hover { color: $link-hover; + text-decoration: underline; } @media screen and (forced-colors: active) { color: linktext; &:hover { - color: linktext; + color: ButtonText !important; + text-decoration: underline; } } } diff --git a/src/common/components/new-tab-link-with-tooltip.scss b/src/common/components/new-tab-link-with-tooltip.scss index d625fac76fa..e1a274697a5 100644 --- a/src/common/components/new-tab-link-with-tooltip.scss +++ b/src/common/components/new-tab-link-with-tooltip.scss @@ -24,8 +24,18 @@ } } +.insights-link-icon { + display: flex; + + &:hover, + &:active { + text-decoration: none !important; + } +} + @media screen and (forced-colors: active) { - .insights-link:hover { + .insights-link:hover, + .insights-link-icon:hover { forced-color-adjust: none; color: ButtonText !important; } diff --git a/src/common/components/new-tab-link-with-tooltip.tsx b/src/common/components/new-tab-link-with-tooltip.tsx index 811984c9dfc..2ed14d5cbeb 100644 --- a/src/common/components/new-tab-link-with-tooltip.tsx +++ b/src/common/components/new-tab-link-with-tooltip.tsx @@ -6,7 +6,9 @@ import * as React from 'react'; import { NamedFC } from '../react/named-fc'; import styles from './new-tab-link-with-tooltip.scss'; -export type NewTabLinkWithTooltipProps = ILinkProps & { tooltipContent: string | undefined }; +export type NewTabLinkWithTooltipProps = ILinkProps & { + tooltipContent: string | undefined; +}; export const NewTabLinkWithTooltip = NamedFC( 'NewTabLinkWithTooltip', @@ -23,7 +25,10 @@ export const NewTabLinkWithTooltip = NamedFC( }; return ( - + ); }, diff --git a/src/tests/unit/tests/views/content/__snapshots__/content-link.test.tsx.snap b/src/tests/unit/tests/views/content/__snapshots__/content-link.test.tsx.snap index 948d2b78643..7ef078f18d8 100644 --- a/src/tests/unit/tests/views/content/__snapshots__/content-link.test.tsx.snap +++ b/src/tests/unit/tests/views/content/__snapshots__/content-link.test.tsx.snap @@ -6,6 +6,7 @@ exports[`ContentLink renders from content, only have the icon 1`] = ` @@ -20,6 +21,7 @@ exports[`ContentLink renders from path, only have the icon 1`] = ` @@ -34,6 +36,7 @@ exports[`ContentLink renders with both text and icon 1`] = ` @@ -49,6 +52,7 @@ exports[`ContentLink renders with only text 1`] = ` diff --git a/src/views/content/content-link.tsx b/src/views/content/content-link.tsx index e9095aeba78..3cf7bdf87fa 100644 --- a/src/views/content/content-link.tsx +++ b/src/views/content/content-link.tsx @@ -4,6 +4,7 @@ import { Icon } from '@fluentui/react'; import { NewTabLink } from 'common/components/new-tab-link'; import { NewTabLinkWithTooltip } from 'common/components/new-tab-link-with-tooltip'; import * as React from 'react'; +import styles from 'common/components/new-tab-link-with-tooltip.scss'; import { ContentActionMessageCreator } from '../../common/message-creators/content-action-message-creator'; import { NamedFC } from '../../common/react/named-fc'; @@ -52,6 +53,7 @@ export const ContentLink = NamedFC( onClick={handleLinkClick} tooltipContent={'Guidance'} aria-label={ariaLabel} + className={styles.insightsLinkIcon} > {icon} {linkText} From ce5f072fa464fb86a6717ab94655af1a3118a145 Mon Sep 17 00:00:00 2001 From: Saanica Ghate Date: Mon, 8 Jul 2024 17:55:17 +0530 Subject: [PATCH 09/16] lint issue resolved(import order) --- src/views/content/content-link.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/views/content/content-link.tsx b/src/views/content/content-link.tsx index 3cf7bdf87fa..96f94bdea9f 100644 --- a/src/views/content/content-link.tsx +++ b/src/views/content/content-link.tsx @@ -3,8 +3,8 @@ import { Icon } from '@fluentui/react'; import { NewTabLink } from 'common/components/new-tab-link'; import { NewTabLinkWithTooltip } from 'common/components/new-tab-link-with-tooltip'; -import * as React from 'react'; import styles from 'common/components/new-tab-link-with-tooltip.scss'; +import * as React from 'react'; import { ContentActionMessageCreator } from '../../common/message-creators/content-action-message-creator'; import { NamedFC } from '../../common/react/named-fc'; From 4d22e0b861c46170bb0a98f5ee7e8faeb466f71a Mon Sep 17 00:00:00 2001 From: Saanica Ghate Date: Tue, 9 Jul 2024 11:49:16 +0530 Subject: [PATCH 10/16] fixed tbuilt issues --- src/common/components/new-tab-link-with-tooltip.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/common/components/new-tab-link-with-tooltip.tsx b/src/common/components/new-tab-link-with-tooltip.tsx index 2ed14d5cbeb..f9a552ac069 100644 --- a/src/common/components/new-tab-link-with-tooltip.tsx +++ b/src/common/components/new-tab-link-with-tooltip.tsx @@ -8,12 +8,13 @@ import styles from './new-tab-link-with-tooltip.scss'; export type NewTabLinkWithTooltipProps = ILinkProps & { tooltipContent: string | undefined; + className?: string | undefined; }; export const NewTabLinkWithTooltip = NamedFC( 'NewTabLinkWithTooltip', props => { - const { tooltipContent, ...linkProps } = props; + const { tooltipContent, className, ...linkProps } = props; const hostStyles: Partial = { root: styles.insightsTooltipHost, }; From 554751737bf511c278ffad96152b644a1c6ff1c5 Mon Sep 17 00:00:00 2001 From: Saanica Ghate Date: Wed, 10 Jul 2024 12:58:49 +0530 Subject: [PATCH 11/16] removed typeOf keyword and updated snapshot accordingly. --- src/common/components/new-tab-link-with-tooltip.tsx | 5 +---- .../__snapshots__/new-tab-link-with-tooltip.test.tsx.snap | 3 --- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/common/components/new-tab-link-with-tooltip.tsx b/src/common/components/new-tab-link-with-tooltip.tsx index f9a552ac069..6b19c340c2d 100644 --- a/src/common/components/new-tab-link-with-tooltip.tsx +++ b/src/common/components/new-tab-link-with-tooltip.tsx @@ -26,10 +26,7 @@ export const NewTabLinkWithTooltip = NamedFC( }; return ( - + ); }, diff --git a/src/tests/unit/tests/common/components/__snapshots__/new-tab-link-with-tooltip.test.tsx.snap b/src/tests/unit/tests/common/components/__snapshots__/new-tab-link-with-tooltip.test.tsx.snap index 4056ecb48c7..be340848534 100644 --- a/src/tests/unit/tests/common/components/__snapshots__/new-tab-link-with-tooltip.test.tsx.snap +++ b/src/tests/unit/tests/common/components/__snapshots__/new-tab-link-with-tooltip.test.tsx.snap @@ -19,7 +19,6 @@ exports[`NewTabLinkWithTooltip handles children: StyledTooltipHostBase props 1`] }, }, "children": link text @@ -49,7 +48,6 @@ exports[`NewTabLinkWithTooltip renders with null tooltip content: StyledTooltipH }, }, "children": , "content": undefined, @@ -78,7 +76,6 @@ exports[`NewTabLinkWithTooltip renders with tooltip content: StyledTooltipHostBa }, }, "children": , "content": "tooltip text", From 613e16bb9595a5d274342622b45a78813ec9f864 Mon Sep 17 00:00:00 2001 From: Saanica Ghate Date: Wed, 10 Jul 2024 13:12:29 +0530 Subject: [PATCH 12/16] snapshot update. --- .../__snapshots__/new-tab-link-with-tooltip.test.tsx.snap | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/tests/unit/tests/common/components/__snapshots__/new-tab-link-with-tooltip.test.tsx.snap b/src/tests/unit/tests/common/components/__snapshots__/new-tab-link-with-tooltip.test.tsx.snap index be340848534..4056ecb48c7 100644 --- a/src/tests/unit/tests/common/components/__snapshots__/new-tab-link-with-tooltip.test.tsx.snap +++ b/src/tests/unit/tests/common/components/__snapshots__/new-tab-link-with-tooltip.test.tsx.snap @@ -19,6 +19,7 @@ exports[`NewTabLinkWithTooltip handles children: StyledTooltipHostBase props 1`] }, }, "children": link text @@ -48,6 +49,7 @@ exports[`NewTabLinkWithTooltip renders with null tooltip content: StyledTooltipH }, }, "children": , "content": undefined, @@ -76,6 +78,7 @@ exports[`NewTabLinkWithTooltip renders with tooltip content: StyledTooltipHostBa }, }, "children": , "content": "tooltip text", From ccf497d3a626d2d33e3929bcef5c3e756e030186 Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Mon, 23 Sep 2024 11:19:38 +0530 Subject: [PATCH 13/16] added underline styling for hover state for command bar link --- src/DetailsView/components/details-view-command-bar.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/DetailsView/components/details-view-command-bar.scss b/src/DetailsView/components/details-view-command-bar.scss index 3ebdcf13238..a5fda5d0266 100644 --- a/src/DetailsView/components/details-view-command-bar.scss +++ b/src/DetailsView/components/details-view-command-bar.scss @@ -38,6 +38,10 @@ text-overflow: ellipsis; display: inline-block; overflow: hidden; + + &:hover { + text-decoration: underline; + } } .target-page-link { From 688d37434c2b80a47d81332b1e2a4abb66ab9a64 Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Mon, 23 Sep 2024 11:44:55 +0530 Subject: [PATCH 14/16] add latest codecov library as current 3.8.3 is deprecated and its failing in CI pipeline --- package.json | 2 +- yarn.lock | 150 ++++----------------------------------------------- 2 files changed, 10 insertions(+), 142 deletions(-) diff --git a/package.json b/package.json index 8a467b7ff18..091020d0c76 100644 --- a/package.json +++ b/package.json @@ -97,7 +97,7 @@ "@typescript-eslint/eslint-plugin": "^5.61.0", "@typescript-eslint/parser": "^6.18.1", "case-sensitive-paths-webpack-plugin": "^2.4.0", - "codecov": "^3.8.3", + "codecov": "4.0.0-0", "commander": "^11.1.0", "core-js-bundle": "^3.35.0", "cross-env": "^7.0.3", diff --git a/yarn.lock b/yarn.lock index 03781196257..25688ae1048 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1929,13 +1929,6 @@ __metadata: languageName: node linkType: hard -"@tootallnate/once@npm:1": - version: 1.1.2 - resolution: "@tootallnate/once@npm:1.1.2" - checksum: e1fb1bbbc12089a0cb9433dc290f97bddd062deadb6178ce9bcb93bb7c1aecde5e60184bc7065aec42fe1663622a213493c48bbd4972d931aae48315f18e1be9 - languageName: node - linkType: hard - "@tootallnate/once@npm:2": version: 2.0.0 resolution: "@tootallnate/once@npm:2.0.0" @@ -2853,7 +2846,7 @@ __metadata: axe-core: 4.9.1 case-sensitive-paths-webpack-plugin: ^2.4.0 classnames: ^2.5.1 - codecov: ^3.8.3 + codecov: 4.0.0-0 commander: ^11.1.0 core-js-bundle: ^3.35.0 cross-env: ^7.0.3 @@ -3138,13 +3131,6 @@ __metadata: languageName: node linkType: hard -"argv@npm:0.0.2": - version: 0.0.2 - resolution: "argv@npm:0.0.2" - checksum: e703f1af475dfd35f4065c21d7324368e3a9f1b5ff63d49c11fd442155aa0fd4f8498b57b535947fac86b79e1c9913cf0324300cbddbdc0af92fcf62eac0f5d2 - languageName: node - linkType: hard - "aria-query@npm:5.3.0, aria-query@npm:^5.0.0": version: 5.3.0 resolution: "aria-query@npm:5.3.0" @@ -3883,18 +3869,12 @@ __metadata: languageName: node linkType: hard -"codecov@npm:^3.8.3": - version: 3.8.3 - resolution: "codecov@npm:3.8.3" - dependencies: - argv: 0.0.2 - ignore-walk: 3.0.4 - js-yaml: 3.14.1 - teeny-request: 7.1.1 - urlgrey: 1.0.0 +"codecov@npm:4.0.0-0": + version: 4.0.0-0 + resolution: "codecov@npm:4.0.0-0" bin: - codecov: bin/codecov - checksum: b7cde26f225930668dce13cb8d1d908187411669debeae6d2e8e561465ca4335575f50a7932256c0fa98e22baf0205f4b2c0225a0fbde02883cc7008ce3e1b9c + codecov: ./bin/codecov + checksum: f0fbfeeecbe725db355c6716787c823944cfaa18c6ddcda70cd92e663d2bb0ec544f3c9d8723b899e8a0ca0d76b44ebf25d2396f24a761f854cba58666afe9ec languageName: node linkType: hard @@ -5538,15 +5518,6 @@ __metadata: languageName: node linkType: hard -"fast-url-parser@npm:^1.1.3": - version: 1.1.3 - resolution: "fast-url-parser@npm:1.1.3" - dependencies: - punycode: ^1.3.2 - checksum: 5043d0c4a8d775ff58504d56c096563c11b113e4cb8a2668c6f824a1cd4fb3812e2fdf76537eb24a7ce4ae7def6bd9747da630c617cf2a4b6ce0c42514e4f21c - languageName: node - linkType: hard - "fastest-levenshtein@npm:^1.0.12, fastest-levenshtein@npm:^1.0.16": version: 1.0.16 resolution: "fastest-levenshtein@npm:1.0.16" @@ -6605,17 +6576,6 @@ __metadata: languageName: node linkType: hard -"http-proxy-agent@npm:^4.0.0": - version: 4.0.1 - resolution: "http-proxy-agent@npm:4.0.1" - dependencies: - "@tootallnate/once": 1 - agent-base: 6 - debug: 4 - checksum: c6a5da5a1929416b6bbdf77b1aca13888013fe7eb9d59fc292e25d18e041bb154a8dfada58e223fc7b76b9b2d155a87e92e608235201f77d34aa258707963a82 - languageName: node - linkType: hard - "http-proxy-agent@npm:^5.0.0": version: 5.0.0 resolution: "http-proxy-agent@npm:5.0.0" @@ -6637,7 +6597,7 @@ __metadata: languageName: node linkType: hard -"https-proxy-agent@npm:^5.0.0, https-proxy-agent@npm:^5.0.1": +"https-proxy-agent@npm:^5.0.1": version: 5.0.1 resolution: "https-proxy-agent@npm:5.0.1" dependencies: @@ -6698,15 +6658,6 @@ __metadata: languageName: node linkType: hard -"ignore-walk@npm:3.0.4": - version: 3.0.4 - resolution: "ignore-walk@npm:3.0.4" - dependencies: - minimatch: ^3.0.4 - checksum: 9e9c5ef6c3e0ed7ef5d797991abb554dbb7e60d5fedf6cf05c7129819689eba2b462f625c6e3561e0fc79841904eb829565513eeeab1b44f4fbec4d3146b1a8d - languageName: node - linkType: hard - "ignore@npm:^5.1.1, ignore@npm:^5.1.2, ignore@npm:^5.2.0, ignore@npm:^5.2.4": version: 5.3.1 resolution: "ignore@npm:5.3.1" @@ -7831,7 +7782,7 @@ __metadata: languageName: node linkType: hard -"js-yaml@npm:3.14.1, js-yaml@npm:^3.13.1, js-yaml@npm:~3.14.0": +"js-yaml@npm:^3.13.1, js-yaml@npm:~3.14.0": version: 3.14.1 resolution: "js-yaml@npm:3.14.1" dependencies: @@ -8754,20 +8705,6 @@ __metadata: languageName: node linkType: hard -"node-fetch@npm:^2.6.1": - version: 2.7.0 - resolution: "node-fetch@npm:2.7.0" - dependencies: - whatwg-url: ^5.0.0 - peerDependencies: - encoding: ^0.1.0 - peerDependenciesMeta: - encoding: - optional: true - checksum: d76d2f5edb451a3f05b15115ec89fc6be39de37c6089f1b6368df03b91e1633fd379a7e01b7ab05089a25034b2023d959b47e59759cb38d88341b2459e89d6e5 - languageName: node - linkType: hard - "node-gyp@npm:latest": version: 10.1.0 resolution: "node-gyp@npm:10.1.0" @@ -9728,13 +9665,6 @@ __metadata: languageName: node linkType: hard -"punycode@npm:^1.3.2": - version: 1.4.1 - resolution: "punycode@npm:1.4.1" - checksum: fa6e698cb53db45e4628559e557ddaf554103d2a96a1d62892c8f4032cd3bc8871796cae9eabc1bc700e2b6677611521ce5bb1d9a27700086039965d0cf34518 - languageName: node - linkType: hard - "punycode@npm:^2.1.0, punycode@npm:^2.1.1": version: 2.3.1 resolution: "punycode@npm:2.3.1" @@ -10806,15 +10736,6 @@ __metadata: languageName: node linkType: hard -"stream-events@npm:^1.0.5": - version: 1.0.5 - resolution: "stream-events@npm:1.0.5" - dependencies: - stubs: ^3.0.0 - checksum: 969ce82e34bfbef5734629cc06f9d7f3705a9ceb8fcd6a526332f9159f1f8bbfdb1a453f3ced0b728083454f7706adbbe8428bceb788a0287ca48ba2642dc3fc - languageName: node - linkType: hard - "stream-shift@npm:^1.0.0": version: 1.0.3 resolution: "stream-shift@npm:1.0.3" @@ -11032,13 +10953,6 @@ __metadata: languageName: node linkType: hard -"stubs@npm:^3.0.0": - version: 3.0.0 - resolution: "stubs@npm:3.0.0" - checksum: dec7b82186e3743317616235c59bfb53284acc312cb9f4c3e97e2205c67a5c158b0ca89db5927e52351582e90a2672822eeaec9db396e23e56893d2a8676e024 - languageName: node - linkType: hard - "style-search@npm:^0.1.0": version: 0.1.0 resolution: "style-search@npm:0.1.0" @@ -11282,19 +11196,6 @@ __metadata: languageName: node linkType: hard -"teeny-request@npm:7.1.1": - version: 7.1.1 - resolution: "teeny-request@npm:7.1.1" - dependencies: - http-proxy-agent: ^4.0.0 - https-proxy-agent: ^5.0.0 - node-fetch: ^2.6.1 - stream-events: ^1.0.5 - uuid: ^8.0.0 - checksum: 3ac6ade7d5ea8c96b6a71c8f7b75dd3f0a939b8c25e9c4ef87edf021264ef07417f2df4ca22f0ff72b3fdccb2616a92cdf2008e0819188e79390a3e79b426a46 - languageName: node - linkType: hard - "temp@npm:^0.8.4": version: 0.8.4 resolution: "temp@npm:0.8.4" @@ -11449,13 +11350,6 @@ __metadata: languageName: node linkType: hard -"tr46@npm:~0.0.3": - version: 0.0.3 - resolution: "tr46@npm:0.0.3" - checksum: 726321c5eaf41b5002e17ffbd1fb7245999a073e8979085dacd47c4b4e8068ff5777142fc6726d6ca1fd2ff16921b48788b87225cbc57c72636f6efa8efbffe3 - languageName: node - linkType: hard - "trim-newlines@npm:^4.0.2": version: 4.1.1 resolution: "trim-newlines@npm:4.1.1" @@ -11845,15 +11739,6 @@ __metadata: languageName: node linkType: hard -"urlgrey@npm:1.0.0": - version: 1.0.0 - resolution: "urlgrey@npm:1.0.0" - dependencies: - fast-url-parser: ^1.1.3 - checksum: bc09df2474da59f95c8577746322bfb0f219c3a084722b427a916906ea7dab538fdbaf6a5582f64f617e9405fb1c9cc437ce40ec73abdddf26d7771a3d2f088b - languageName: node - linkType: hard - "util-deprecate@npm:^1.0.2, util-deprecate@npm:~1.0.1": version: 1.0.2 resolution: "util-deprecate@npm:1.0.2" @@ -11868,7 +11753,7 @@ __metadata: languageName: node linkType: hard -"uuid@npm:^8.0.0, uuid@npm:^8.3.2": +"uuid@npm:^8.3.2": version: 8.3.2 resolution: "uuid@npm:8.3.2" bin: @@ -11958,13 +11843,6 @@ __metadata: languageName: node linkType: hard -"webidl-conversions@npm:^3.0.0": - version: 3.0.1 - resolution: "webidl-conversions@npm:3.0.1" - checksum: c92a0a6ab95314bde9c32e1d0a6dfac83b578f8fa5f21e675bc2706ed6981bc26b7eb7e6a1fab158e5ce4adf9caa4a0aee49a52505d4d13c7be545f15021b17c - languageName: node - linkType: hard - "webidl-conversions@npm:^4.0.2": version: 4.0.2 resolution: "webidl-conversions@npm:4.0.2" @@ -12124,16 +12002,6 @@ __metadata: languageName: node linkType: hard -"whatwg-url@npm:^5.0.0": - version: 5.0.0 - resolution: "whatwg-url@npm:5.0.0" - dependencies: - tr46: ~0.0.3 - webidl-conversions: ^3.0.0 - checksum: b8daed4ad3356cc4899048a15b2c143a9aed0dfae1f611ebd55073310c7b910f522ad75d727346ad64203d7e6c79ef25eafd465f4d12775ca44b90fa82ed9e2c - languageName: node - linkType: hard - "whatwg-url@npm:^8.4.0": version: 8.7.0 resolution: "whatwg-url@npm:8.7.0" From cbe7bb9fd391f622bcb2fa5d3638878265b4a166 Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Mon, 23 Sep 2024 19:34:05 +0530 Subject: [PATCH 15/16] resolve codecov version --- package.json | 2 +- yarn.lock | 150 +++++++++++++++++++++++++++++++++++++++++++++++---- 2 files changed, 142 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index a775216dca8..46d77921cbf 100644 --- a/package.json +++ b/package.json @@ -98,7 +98,7 @@ "@typescript-eslint/eslint-plugin": "^5.61.0", "@typescript-eslint/parser": "^6.18.1", "case-sensitive-paths-webpack-plugin": "^2.4.0", - "codecov": "4.0.0-0", + "codecov": "^3.8.3", "commander": "^11.1.0", "core-js-bundle": "^3.35.0", "cross-env": "^7.0.3", diff --git a/yarn.lock b/yarn.lock index 9973f412c96..5f938e2ec01 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2191,6 +2191,13 @@ __metadata: languageName: node linkType: hard +"@tootallnate/once@npm:1": + version: 1.1.2 + resolution: "@tootallnate/once@npm:1.1.2" + checksum: e1fb1bbbc12089a0cb9433dc290f97bddd062deadb6178ce9bcb93bb7c1aecde5e60184bc7065aec42fe1663622a213493c48bbd4972d931aae48315f18e1be9 + languageName: node + linkType: hard + "@tootallnate/once@npm:2": version: 2.0.0 resolution: "@tootallnate/once@npm:2.0.0" @@ -3109,7 +3116,7 @@ __metadata: axe-core: 4.9.1 case-sensitive-paths-webpack-plugin: ^2.4.0 classnames: ^2.5.1 - codecov: 4.0.0-0 + codecov: ^3.8.3 commander: ^11.1.0 core-js-bundle: ^3.35.0 cross-env: ^7.0.3 @@ -3394,6 +3401,13 @@ __metadata: languageName: node linkType: hard +"argv@npm:0.0.2": + version: 0.0.2 + resolution: "argv@npm:0.0.2" + checksum: e703f1af475dfd35f4065c21d7324368e3a9f1b5ff63d49c11fd442155aa0fd4f8498b57b535947fac86b79e1c9913cf0324300cbddbdc0af92fcf62eac0f5d2 + languageName: node + linkType: hard + "aria-query@npm:5.3.0, aria-query@npm:^5.0.0": version: 5.3.0 resolution: "aria-query@npm:5.3.0" @@ -4123,12 +4137,18 @@ __metadata: languageName: node linkType: hard -"codecov@npm:4.0.0-0": - version: 4.0.0-0 - resolution: "codecov@npm:4.0.0-0" +"codecov@npm:^3.8.3": + version: 3.8.3 + resolution: "codecov@npm:3.8.3" + dependencies: + argv: 0.0.2 + ignore-walk: 3.0.4 + js-yaml: 3.14.1 + teeny-request: 7.1.1 + urlgrey: 1.0.0 bin: - codecov: ./bin/codecov - checksum: f0fbfeeecbe725db355c6716787c823944cfaa18c6ddcda70cd92e663d2bb0ec544f3c9d8723b899e8a0ca0d76b44ebf25d2396f24a761f854cba58666afe9ec + codecov: bin/codecov + checksum: b7cde26f225930668dce13cb8d1d908187411669debeae6d2e8e561465ca4335575f50a7932256c0fa98e22baf0205f4b2c0225a0fbde02883cc7008ce3e1b9c languageName: node linkType: hard @@ -5773,6 +5793,15 @@ __metadata: languageName: node linkType: hard +"fast-url-parser@npm:^1.1.3": + version: 1.1.3 + resolution: "fast-url-parser@npm:1.1.3" + dependencies: + punycode: ^1.3.2 + checksum: 5043d0c4a8d775ff58504d56c096563c11b113e4cb8a2668c6f824a1cd4fb3812e2fdf76537eb24a7ce4ae7def6bd9747da630c617cf2a4b6ce0c42514e4f21c + languageName: node + linkType: hard + "fastest-levenshtein@npm:^1.0.12, fastest-levenshtein@npm:^1.0.16": version: 1.0.16 resolution: "fastest-levenshtein@npm:1.0.16" @@ -6831,6 +6860,17 @@ __metadata: languageName: node linkType: hard +"http-proxy-agent@npm:^4.0.0": + version: 4.0.1 + resolution: "http-proxy-agent@npm:4.0.1" + dependencies: + "@tootallnate/once": 1 + agent-base: 6 + debug: 4 + checksum: c6a5da5a1929416b6bbdf77b1aca13888013fe7eb9d59fc292e25d18e041bb154a8dfada58e223fc7b76b9b2d155a87e92e608235201f77d34aa258707963a82 + languageName: node + linkType: hard + "http-proxy-agent@npm:^5.0.0": version: 5.0.0 resolution: "http-proxy-agent@npm:5.0.0" @@ -6852,7 +6892,7 @@ __metadata: languageName: node linkType: hard -"https-proxy-agent@npm:^5.0.1": +"https-proxy-agent@npm:^5.0.0, https-proxy-agent@npm:^5.0.1": version: 5.0.1 resolution: "https-proxy-agent@npm:5.0.1" dependencies: @@ -6913,6 +6953,15 @@ __metadata: languageName: node linkType: hard +"ignore-walk@npm:3.0.4": + version: 3.0.4 + resolution: "ignore-walk@npm:3.0.4" + dependencies: + minimatch: ^3.0.4 + checksum: 9e9c5ef6c3e0ed7ef5d797991abb554dbb7e60d5fedf6cf05c7129819689eba2b462f625c6e3561e0fc79841904eb829565513eeeab1b44f4fbec4d3146b1a8d + languageName: node + linkType: hard + "ignore@npm:^5.1.1, ignore@npm:^5.1.2, ignore@npm:^5.2.0, ignore@npm:^5.2.4": version: 5.3.1 resolution: "ignore@npm:5.3.1" @@ -8037,7 +8086,7 @@ __metadata: languageName: node linkType: hard -"js-yaml@npm:^3.13.1, js-yaml@npm:~3.14.0": +"js-yaml@npm:3.14.1, js-yaml@npm:^3.13.1, js-yaml@npm:~3.14.0": version: 3.14.1 resolution: "js-yaml@npm:3.14.1" dependencies: @@ -8980,6 +9029,20 @@ __metadata: languageName: node linkType: hard +"node-fetch@npm:^2.6.1": + version: 2.7.0 + resolution: "node-fetch@npm:2.7.0" + dependencies: + whatwg-url: ^5.0.0 + peerDependencies: + encoding: ^0.1.0 + peerDependenciesMeta: + encoding: + optional: true + checksum: d76d2f5edb451a3f05b15115ec89fc6be39de37c6089f1b6368df03b91e1633fd379a7e01b7ab05089a25034b2023d959b47e59759cb38d88341b2459e89d6e5 + languageName: node + linkType: hard + "node-gyp@npm:latest": version: 10.1.0 resolution: "node-gyp@npm:10.1.0" @@ -9940,6 +10003,13 @@ __metadata: languageName: node linkType: hard +"punycode@npm:^1.3.2": + version: 1.4.1 + resolution: "punycode@npm:1.4.1" + checksum: fa6e698cb53db45e4628559e557ddaf554103d2a96a1d62892c8f4032cd3bc8871796cae9eabc1bc700e2b6677611521ce5bb1d9a27700086039965d0cf34518 + languageName: node + linkType: hard + "punycode@npm:^2.1.0, punycode@npm:^2.1.1": version: 2.3.1 resolution: "punycode@npm:2.3.1" @@ -11011,6 +11081,15 @@ __metadata: languageName: node linkType: hard +"stream-events@npm:^1.0.5": + version: 1.0.5 + resolution: "stream-events@npm:1.0.5" + dependencies: + stubs: ^3.0.0 + checksum: 969ce82e34bfbef5734629cc06f9d7f3705a9ceb8fcd6a526332f9159f1f8bbfdb1a453f3ced0b728083454f7706adbbe8428bceb788a0287ca48ba2642dc3fc + languageName: node + linkType: hard + "stream-shift@npm:^1.0.0": version: 1.0.3 resolution: "stream-shift@npm:1.0.3" @@ -11238,6 +11317,13 @@ __metadata: languageName: node linkType: hard +"stubs@npm:^3.0.0": + version: 3.0.0 + resolution: "stubs@npm:3.0.0" + checksum: dec7b82186e3743317616235c59bfb53284acc312cb9f4c3e97e2205c67a5c158b0ca89db5927e52351582e90a2672822eeaec9db396e23e56893d2a8676e024 + languageName: node + linkType: hard + "style-search@npm:^0.1.0": version: 0.1.0 resolution: "style-search@npm:0.1.0" @@ -11481,6 +11567,19 @@ __metadata: languageName: node linkType: hard +"teeny-request@npm:7.1.1": + version: 7.1.1 + resolution: "teeny-request@npm:7.1.1" + dependencies: + http-proxy-agent: ^4.0.0 + https-proxy-agent: ^5.0.0 + node-fetch: ^2.6.1 + stream-events: ^1.0.5 + uuid: ^8.0.0 + checksum: 3ac6ade7d5ea8c96b6a71c8f7b75dd3f0a939b8c25e9c4ef87edf021264ef07417f2df4ca22f0ff72b3fdccb2616a92cdf2008e0819188e79390a3e79b426a46 + languageName: node + linkType: hard + "temp@npm:^0.9.4": version: 0.9.4 resolution: "temp@npm:0.9.4" @@ -11636,6 +11735,13 @@ __metadata: languageName: node linkType: hard +"tr46@npm:~0.0.3": + version: 0.0.3 + resolution: "tr46@npm:0.0.3" + checksum: 726321c5eaf41b5002e17ffbd1fb7245999a073e8979085dacd47c4b4e8068ff5777142fc6726d6ca1fd2ff16921b48788b87225cbc57c72636f6efa8efbffe3 + languageName: node + linkType: hard + "trim-newlines@npm:^4.0.2": version: 4.1.1 resolution: "trim-newlines@npm:4.1.1" @@ -12025,6 +12131,15 @@ __metadata: languageName: node linkType: hard +"urlgrey@npm:1.0.0": + version: 1.0.0 + resolution: "urlgrey@npm:1.0.0" + dependencies: + fast-url-parser: ^1.1.3 + checksum: bc09df2474da59f95c8577746322bfb0f219c3a084722b427a916906ea7dab538fdbaf6a5582f64f617e9405fb1c9cc437ce40ec73abdddf26d7771a3d2f088b + languageName: node + linkType: hard + "util-deprecate@npm:^1.0.2, util-deprecate@npm:~1.0.1": version: 1.0.2 resolution: "util-deprecate@npm:1.0.2" @@ -12039,7 +12154,7 @@ __metadata: languageName: node linkType: hard -"uuid@npm:^8.3.2": +"uuid@npm:^8.0.0, uuid@npm:^8.3.2": version: 8.3.2 resolution: "uuid@npm:8.3.2" bin: @@ -12129,6 +12244,13 @@ __metadata: languageName: node linkType: hard +"webidl-conversions@npm:^3.0.0": + version: 3.0.1 + resolution: "webidl-conversions@npm:3.0.1" + checksum: c92a0a6ab95314bde9c32e1d0a6dfac83b578f8fa5f21e675bc2706ed6981bc26b7eb7e6a1fab158e5ce4adf9caa4a0aee49a52505d4d13c7be545f15021b17c + languageName: node + linkType: hard + "webidl-conversions@npm:^4.0.2": version: 4.0.2 resolution: "webidl-conversions@npm:4.0.2" @@ -12288,6 +12410,16 @@ __metadata: languageName: node linkType: hard +"whatwg-url@npm:^5.0.0": + version: 5.0.0 + resolution: "whatwg-url@npm:5.0.0" + dependencies: + tr46: ~0.0.3 + webidl-conversions: ^3.0.0 + checksum: b8daed4ad3356cc4899048a15b2c143a9aed0dfae1f611ebd55073310c7b910f522ad75d727346ad64203d7e6c79ef25eafd465f4d12775ca44b90fa82ed9e2c + languageName: node + linkType: hard + "whatwg-url@npm:^8.4.0": version: 8.7.0 resolution: "whatwg-url@npm:8.7.0" From 6663c67b82463c6f1374205d9f768c69fd702d11 Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Tue, 24 Sep 2024 10:41:48 +0530 Subject: [PATCH 16/16] resolve codecov version --- package.json | 2 +- yarn.lock | 58 ++++++++++++++++++---------------------------------- 2 files changed, 21 insertions(+), 39 deletions(-) diff --git a/package.json b/package.json index 46d77921cbf..6925727ff58 100644 --- a/package.json +++ b/package.json @@ -98,7 +98,7 @@ "@typescript-eslint/eslint-plugin": "^5.61.0", "@typescript-eslint/parser": "^6.18.1", "case-sensitive-paths-webpack-plugin": "^2.4.0", - "codecov": "^3.8.3", + "codecov": "3.8.2", "commander": "^11.1.0", "core-js-bundle": "^3.35.0", "cross-env": "^7.0.3", diff --git a/yarn.lock b/yarn.lock index 5f938e2ec01..e64f7cee2a2 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3116,7 +3116,7 @@ __metadata: axe-core: 4.9.1 case-sensitive-paths-webpack-plugin: ^2.4.0 classnames: ^2.5.1 - codecov: ^3.8.3 + codecov: 3.8.2 commander: ^11.1.0 core-js-bundle: ^3.35.0 cross-env: ^7.0.3 @@ -4137,18 +4137,18 @@ __metadata: languageName: node linkType: hard -"codecov@npm:^3.8.3": - version: 3.8.3 - resolution: "codecov@npm:3.8.3" +"codecov@npm:3.8.2": + version: 3.8.2 + resolution: "codecov@npm:3.8.2" dependencies: argv: 0.0.2 - ignore-walk: 3.0.4 + ignore-walk: 3.0.3 js-yaml: 3.14.1 - teeny-request: 7.1.1 - urlgrey: 1.0.0 + teeny-request: 7.0.1 + urlgrey: 0.4.4 bin: codecov: bin/codecov - checksum: b7cde26f225930668dce13cb8d1d908187411669debeae6d2e8e561465ca4335575f50a7932256c0fa98e22baf0205f4b2c0225a0fbde02883cc7008ce3e1b9c + checksum: a70fdf2e83dace9018747781e63a564c935784ab62df966eebe7f6bacfd004a6f8b0c271fc9814fea21726e118501c35a05d65c74770b0573760c96e5dfa04d9 languageName: node linkType: hard @@ -5793,15 +5793,6 @@ __metadata: languageName: node linkType: hard -"fast-url-parser@npm:^1.1.3": - version: 1.1.3 - resolution: "fast-url-parser@npm:1.1.3" - dependencies: - punycode: ^1.3.2 - checksum: 5043d0c4a8d775ff58504d56c096563c11b113e4cb8a2668c6f824a1cd4fb3812e2fdf76537eb24a7ce4ae7def6bd9747da630c617cf2a4b6ce0c42514e4f21c - languageName: node - linkType: hard - "fastest-levenshtein@npm:^1.0.12, fastest-levenshtein@npm:^1.0.16": version: 1.0.16 resolution: "fastest-levenshtein@npm:1.0.16" @@ -6953,12 +6944,12 @@ __metadata: languageName: node linkType: hard -"ignore-walk@npm:3.0.4": - version: 3.0.4 - resolution: "ignore-walk@npm:3.0.4" +"ignore-walk@npm:3.0.3": + version: 3.0.3 + resolution: "ignore-walk@npm:3.0.3" dependencies: minimatch: ^3.0.4 - checksum: 9e9c5ef6c3e0ed7ef5d797991abb554dbb7e60d5fedf6cf05c7129819689eba2b462f625c6e3561e0fc79841904eb829565513eeeab1b44f4fbec4d3146b1a8d + checksum: 34bc6f0497276a9bfad7ba1ae301c7d16bc6424890755a21d90536eaa1f4b7acd598686a01033e64345483b2fef41dad8f93794af73c8b13a7cf21a3cae34a4e languageName: node linkType: hard @@ -10003,13 +9994,6 @@ __metadata: languageName: node linkType: hard -"punycode@npm:^1.3.2": - version: 1.4.1 - resolution: "punycode@npm:1.4.1" - checksum: fa6e698cb53db45e4628559e557ddaf554103d2a96a1d62892c8f4032cd3bc8871796cae9eabc1bc700e2b6677611521ce5bb1d9a27700086039965d0cf34518 - languageName: node - linkType: hard - "punycode@npm:^2.1.0, punycode@npm:^2.1.1": version: 2.3.1 resolution: "punycode@npm:2.3.1" @@ -11567,16 +11551,16 @@ __metadata: languageName: node linkType: hard -"teeny-request@npm:7.1.1": - version: 7.1.1 - resolution: "teeny-request@npm:7.1.1" +"teeny-request@npm:7.0.1": + version: 7.0.1 + resolution: "teeny-request@npm:7.0.1" dependencies: http-proxy-agent: ^4.0.0 https-proxy-agent: ^5.0.0 node-fetch: ^2.6.1 stream-events: ^1.0.5 uuid: ^8.0.0 - checksum: 3ac6ade7d5ea8c96b6a71c8f7b75dd3f0a939b8c25e9c4ef87edf021264ef07417f2df4ca22f0ff72b3fdccb2616a92cdf2008e0819188e79390a3e79b426a46 + checksum: 8eba49422edc141cff2c4a4c2bc39c78d92b6a9ce0fbf1a9edd0d3a57b830f719a1030a5681c2890a7d222c7ebcb74b7a8c29b37ad7b124d34be728cacfd128b languageName: node linkType: hard @@ -12131,12 +12115,10 @@ __metadata: languageName: node linkType: hard -"urlgrey@npm:1.0.0": - version: 1.0.0 - resolution: "urlgrey@npm:1.0.0" - dependencies: - fast-url-parser: ^1.1.3 - checksum: bc09df2474da59f95c8577746322bfb0f219c3a084722b427a916906ea7dab538fdbaf6a5582f64f617e9405fb1c9cc437ce40ec73abdddf26d7771a3d2f088b +"urlgrey@npm:0.4.4": + version: 0.4.4 + resolution: "urlgrey@npm:0.4.4" + checksum: db5884ffca497430eb99fcf7bd88402ff3647c1ba7b5687c595d3af884afc198399301ec181582501ff61074d9bf342ad12825eb11aa020bc6aeae7bc815a04c languageName: node linkType: hard