-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add Kali to modern distributions #12472
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution to WSL.
The following fatal errors have been found in this pull request:
- kali/None: Found no default distribution
The following suggestions have been found in this pull request:
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
- kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
- kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service
@microsoft-github-policy-service agree company="OffSec" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution to WSL.
No fatal errors have been found.
The following suggestions have been found in this pull request:
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
- kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/local-fs.target.wants/tmp.mount
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup.service
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev.service
- kali/kali-linux: Found discouraged system unit: /usr/lib/systemd/system/sysinit.target.wants/systemd-tmpfiles-setup-dev-early.service
- kali/kali-linux: Found discouraged system unit: /etc/systemd/system/network-online.target.wants/networking.service
Thank you @Gamb1ts ! Feel free to ignore the bot's warnings on the masked systemd units, I need to go fix that ! The tar & manifest look great ! One small suggestion that I have would to use Something like this should do the trick:
|
What's the goal of sleeping to wait for systemd in the oobe script? If you want to make sure that no user processes are launched before systemd is up, that should already be guaranteed as part of WSL. Is that not the behavior you are seeing? |
Early in my testing I found that the system setup was too quick which led to issues using certain commands. However, this was prior to masking the recommended systemd units. I will re-visit this and see if in its current state the wait is necessary. Unfortunately I will have to mark this as WIP until next week, we will need to change where we host the image. Next week I will supply the new URL and checksums. |
No description provided.