Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab for issues #145

Closed
micmro opened this issue Feb 12, 2017 · 6 comments
Closed

Tab for issues #145

micmro opened this issue Feb 12, 2017 · 6 comments
Assignees
@micmro
Labels
ui/ux

Comments

@micmro
Copy link
Owner

micmro commented Feb 12, 2017

In order to only show one warning icon (#129) it would be useful to show all warnings in a tab in the details view.
@micmro micmro added the ui/ux label Feb 12, 2017
@micmro micmro self-assigned this Feb 12, 2017
@tobli
Copy link
Collaborator

tobli commented Feb 12, 2017

Yes, I've been thinking about this too. Maybe put it in the General tab, that way it's instantly available. There shouldn't be more than a handful of warnings anyway per resource.

@soulgalore
Copy link
Collaborator

I like that too. If we could move http push so it is inline to the right of the bar (like wpt display error code for 302 etc) then it would be perfect.

micmro pushed a commit that referenced this issue Feb 12, 2017
#145 working in seperate tab
9dc26a2
@micmro
Copy link
Owner Author

micmro commented Feb 12, 2017

Got a prototype with a separate tab working (see branch 145). But it will be better in the general tab. Will do so later.

As part of this I also moved the indicator scanning logic to parse time as preparation for #56 and others.

@tobli
Copy link
Collaborator

tobli commented Feb 12, 2017

Great

micmro pushed a commit that referenced this issue Feb 12, 2017
#145 move indicators to general tab
e55f919
micmro pushed a commit that referenced this issue Feb 12, 2017
#145 move indicators to general tab
64612ed
@micmro
Copy link
Owner Author

micmro commented Feb 12, 2017

Updated - see PR
screen shot 2017-02-12 at 9 49 40 pm

micmro pushed a commit that referenced this issue Feb 12, 2017
#145 working in seperate tab
921ce7b
micmro pushed a commit that referenced this issue Feb 12, 2017
#145 move indicators to general tab
45bf56d
micmro pushed a commit that referenced this issue Feb 12, 2017
#145 move indicators to general tab
0fa69f4
@soulgalore soulgalore mentioned this issue Feb 12, 2017
Closed
micmro added a commit that referenced this issue Feb 13, 2017
@micmro
#145 Add warnings and infos to general Tab and #129 show only the hig…
08f2cd2 
…hest pritority icon

* #145 show indicators to general tab
* ensure linting via travis
* #129 show only the highest pritority icon
@micmro
Copy link
Owner Author

micmro commented Feb 13, 2017

released via v0.4.0

@micmro micmro closed this as completed Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micmro micmro

Labels
ui/ux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tobli @soulgalore @micmro