Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Only allow connecting to specified connections when array given in config #642

Open
mwllgr opened this issue Nov 10, 2023 · 2 comments

Comments

@mwllgr
Copy link

mwllgr commented Nov 10, 2023

Hello,

I specified a single SMB connection in my configuration:

    "connections": [
        {
            "advanced": false,
            "domain": "FSRV",
            "host": "fsrv",
            "label": "fsrv",
            "path": null,
            "port": 445,
            "share": null,
            "type": "samba"
        }
    ]

This also removes every other connection method from the login form - greatly appreciated for my use case!
Screenshot_20231110_222508

However, manipulating the POST request from the login still seems to allow the user to log in on other hosts / IP addresses in the network:

Screenshot_20231110_222842

In my example, this didn't work as DNS requests are not allowed inside the network.

In my opinion, when specifying connections in the config, there should be a switch to only allow the specific type-host-combination or a general whitelisting feature to prevent access to other hosts in the network. Right now, I'm dealing with this situation by creating a custom Docker network which is restricted in terms of allowed outgoing traffic/ports.

@mickael-kerjean
Copy link
Owner

That feature you are using isn't documented for the reason you describe. Also that's one of the many reason why I've made authentication middleware. Once the new frontend is done, that feature will disappear and what you're doing won't be possible at all.

@mwllgr
Copy link
Author

mwllgr commented Nov 27, 2023

Got it, thanks. Already thought of that - any other way to restrict the server the user connects to, @mickael-kerjean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants