Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

4.0.0-alpha.9 not compatible with https://github.com/STARRY-S/zip/tags 0.2.1 #428

Closed
Slach opened this issue Nov 16, 2024 · 6 comments
Closed

Comments

@Slach
Copy link

Slach commented Nov 16, 2024

What version of the package or command are you using?

my go.mod

        github.com/mholt/archiver/v4 v4.0.0-alpha.9
	github.com/STARRY-S/zip v0.2.1 // indirect

What are you trying to do?

go build ./cmd/ -o test

What steps did you take?

main.go

import (
	"os"
  	"github.com/mholt/archiver/v4"
)

func main() {
  a := &archiver.CompressedArchive{Archival: archiver.Tar{}}
  reader := os.Open("file.tar")
  if err := z.Extract(ctx, reader, nil, func(ctx context.Context, file archiver.File) error {
     return nil
  })
}

What did you expect to happen, and what actually happened instead?

Successful compilation

What actually happens

1.156 /root/go/pkg/mod/github.com/mholt/archiver/[email protected]/zip.go:311:16: zu.AppendHeaderAt undefined (type *"github.com/STARRY-S/zip".Updater has no field or method AppendHeaderAt)

How do you think this should be fixed?

I pope it could be easy to fix.

@mholt
Copy link
Owner

mholt commented Nov 16, 2024

I'm not sure I follow. Our go.mod uses v0.1.0 of STARRY-S/zip:

github.com/STARRY-S/zip v0.1.0

So I do not see why v0.2.1 is expected to succeed when we are targeting a different version. 🤔

@mholt
Copy link
Owner

mholt commented Nov 18, 2024

Looking at this again, I first read it as a bug report (because it uses the bug report template), but I wonder if you're actually asking for a feature request (support a new version of a dependency).

There is no bug here, but there is a request for something new.

Do you want to try c932b56 (or latest on master) to see if that fixes it for you?

Will close, but we can reopen if necessary.

@Slach
Copy link
Author

Slach commented Nov 18, 2024

thanks you, will wait next release

@mholt
Copy link
Owner

mholt commented Nov 18, 2024

@Slach FYI, the next release might be at https://github.com/mholt/archives (see #427)

@Slach
Copy link
Author

Slach commented Nov 18, 2024

i know, i hope you just rename github repository and change go.mod

@mholt
Copy link
Owner

mholt commented Nov 18, 2024

Probably will be archiving this (heh) so as not to break existing users.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants