-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How does the parser deal with multiple countries? #15
Comments
The parser doesn't download the DK file, you have to download it yourself and call the parser with the file name. Now you could download yesterday's DK key set from WAC currently uses the latter. The Would be interesting to learn more about the difference between these two sets. |
Ah great, thanks. Yeah, sorry for being sloppy regarding the parser's role. So there are different countries, and EUR presumably includes all participating countries, whereas DE is just Germany. The dashboards presumably use just DE but that needs to be checked one by one. What was the default? DE, and EUR was introduced later? |
See https://covidapps.slack.com/archives/C0194ML0MLN/p1608741919207700 |
The UK set now includes a few countries and is available from the endpoints in the code here: https://github.com/russss/nhs-covid19-app-data
Note that it doesn’t save the zip files without some minor changes.
I’d be interested to compare files to see who has the same keys and understand which countries are sharing data now.
… On 23 Dec 2020, at 17:10, Michael Huebler ***@***.***> wrote:
See https://covidapps.slack.com/archives/C0194ML0MLN/p1608741919207700
The DE file has 51684 keys, the EUR file has 52589 keys.
So I don't think that EUR includes all participating countries, whereas DE is just Germany.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@tkerby The German distribution at https://svc90.main.px.t-online.de/version/v1/diagnosis-keys/country/EUR/date/2020-12-22 |
Hi! Recently Slovenia joined the EUR exchange and foreign keys caused a significant bump in our charts on 2021-02-10: ...hiding the interesting local details On that day the number of keys grew significantly more in the EUR export (17232), compared to the SI export (4456), meaning that only a subset of EUR keys is included in the SI export. It would be very interesting to allow filtering out those keys coming from EUR exchange, but am not sure this is possible. Is it? I presume the same problem applies for other smaller countries (compared to Germany, at least). |
I don't think there's a way to filter the keys by country of origin, unless your country's server distributes different packages for that purpose. The data does not contain a "country of origin" field. |
National health service distributes packages for SI and EUR region. SI is subset of EUR, they both include keys from Slovenia, so there's no way to just substract EUR keys from the ones in SI 😞 Maybe we could do something by substracting all other countries' packages... |
Ever since the CWA supports multiple countries, I'm wondering how you deal with that fact?
I'm very curious how the setup is:
Obviously this has implications for the interpretation of key numbers. I somehow assume that the dashboards have been able to filter to Germany etc. but it'd be reassuring if you could confirm how this works. Thanks!
The text was updated successfully, but these errors were encountered: