Error creating permalinks with :date

[vctrtvfrrr]

Describe the bug
I always get an error when generating permalinks that include dates, regardless date format and options chosen.

To Reproduce
Sample markdown files:

Technology/Articles/Path/To/HTML Tutorial.md
Technology/Articles/Some Article.md
Technology/Notes/another-article.md

Each markdown file contains the attributes:

---
title: Article title
date: 2024-11-01
---

Metalsmith script config:

  // ...
  .use(
    permalinks({
      linksets: [
        {
          match: { collection: "techArticles" },
          pattern: "technology/articles/:date/:basename",
          date: "YYYY",
        },
        {
          match: { collection: "techNotes" },
          pattern: "technology/notes/:date/:basename",
          date: "YYYY",
        },
      ],
      trailingSlash: true,
      date: "YYYY",
    })
  )
  // ...

Error message:

file:///path/to/project/node_modules/.pnpm/@[email protected][email protected]/node_modules/@metalsmith/permalinks/lib/index.js:398
        return done(new Error(msg));
                    ^

Error: Filepath "Technology/Articles/Some Article.md.html" contains invalid filepath characters (one of :|<>"*?) after resolving as linkset pattern "technology/articles/:date/:basename"
    at file:///path/to/project/node_modules/.pnpm/@[email protected][email protected]/node_modules/@metalsmith/permalinks/lib/index.js:398:21
    at Array.forEach (<anonymous>)
    at Ware.permalinks (file:///path/to/project/node_modules/.pnpm/@[email protected][email protected]/node_modules/@metalsmith/permalinks/lib/index.js:365:104)
    at Ware.<anonymous> (/path/to/project/node_modules/.pnpm/[email protected]/node_modules/wrap-fn/index.js:45:19)
    at next (/path/to/project/node_modules/.pnpm/[email protected]/node_modules/ware/lib/index.js:85:20)
    at /path/to/project/node_modules/.pnpm/[email protected]/node_modules/wrap-fn/index.js:121:18
    at Ware.collections (file:///path/to/project/node_modules/.pnpm/@[email protected][email protected]/node_modules/@metalsmith/collections/lib/index.js:209:5)
    at Ware.<anonymous> (/path/to/project/node_modules/.pnpm/[email protected]/node_modules/wrap-fn/index.js:45:19)
    at next (/path/to/project/node_modules/.pnpm/[email protected]/node_modules/ware/lib/index.js:85:20)
    at /path/to/project/node_modules/.pnpm/[email protected]/node_modules/wrap-fn/index.js:121:18

Environment

• Ubuntu 24.04
• Node.js v20.18.0
• npm 10.9.0

[webketje]

Hi there, I'd have to set up a minimum repro, I'm failing to reproduce this by altering the "should format a date" unit test.
Tested spaces in path, different configs. It may be an unspotted bug to do with multiple . dots in filename.

Evidently the path should not contain invalid filepath characters when the placeholders (:date) etc are resolved.

Is it maybe that not all of the matched files have a :dateproperty? Even then, you should get a different error:

Error: Could not substitute ':date' in pattern ':date/:basename', 'date' is undefined for file 'index.html'

What happens when you make the :date? placeholder optional? (adding a question mark)
Running your script with DEBUG=@metalsmith/permalinks* may give you more info

[vctrtvfrrr]

I opened a pull request with a possible fix for this issue. It seems that the error is related to the resolution of the date formatting function.

I also added a new test scenario that reproduces my issue.

#144