Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a code coverage workflow job #91

Open
ddundo opened this issue Dec 14, 2024 · 3 comments
Open

Set up a code coverage workflow job #91

ddundo opened this issue Dec 14, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request testing Extensions and improvements to the testing infrastructure

Comments

@ddundo
Copy link
Member

ddundo commented Dec 14, 2024

At some point I looked into setting up a code coverage check that would fail if the coverage decreased due to a PR but I couldn't find a decent solution for free. There's a tool called code-cov but I think you have to pay for it.

Originally posted by @jwallwork23 in mesh-adaptation/movement#139 (comment)

I'm perhaps overly confident, but I could probably code this up in two steps:

  • The test suite on the main branch uploads the coverage report as an artifact (with maximum allowed retention time)
  • The test suite on a PR compares its new coverage report with the one uploaded from the main branch
@ddundo ddundo self-assigned this Dec 14, 2024
@ddundo ddundo added enhancement New feature or request testing Extensions and improvements to the testing infrastructure labels Dec 14, 2024
@ddundo
Copy link
Member Author

ddundo commented Dec 14, 2024

I also wouldn't be surprised if there's already an action for this. I'll check

@ddundo ddundo transferred this issue from mesh-adaptation/movement Dec 14, 2024
@ddundo
Copy link
Member Author

ddundo commented Dec 15, 2024

Codecov seems to be free and unlimited for open-source public repos: https://about.codecov.io/pricing/

And there is indeed an action already: https://github.com/marketplace/actions/code-coverage-report-difference https://github.com/GreatWizard/coverage-diff-action

@ddundo ddundo removed their assignment Dec 15, 2024
@ddundo ddundo moved this from Backlog to Discuss in Mesh Adaptation development board Jan 14, 2025
@jwallwork23 jwallwork23 assigned ddundo and unassigned jwallwork23 Jan 17, 2025
@jwallwork23
Copy link
Member

And there is indeed an action already: https://github.com/marketplace/actions/code-coverage-report-difference

We agreed to go for this one.

@ddundo ddundo moved this from Discuss to Backlog in Mesh Adaptation development board Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing Extensions and improvements to the testing infrastructure
Projects
Development

No branches or pull requests

2 participants