From f0d68e4aaaa227e37fadc4ed72bc25ab4c414017 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tobias=20Cad=C3=A9e?= <tobias.cadee@ticketswap.com>
Date: Thu, 29 Aug 2024 17:10:27 +0200
Subject: [PATCH] refactor: :fire: remove `dialect+driver` and `sqlalchemy_url`
 from settings (#1824)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com>
---
 .../loaders/target-redshift/ticketswap.yml    | 36 +++++--------------
 1 file changed, 8 insertions(+), 28 deletions(-)

diff --git a/_data/meltano/loaders/target-redshift/ticketswap.yml b/_data/meltano/loaders/target-redshift/ticketswap.yml
index c14010411..215d6e482 100644
--- a/_data/meltano/loaders/target-redshift/ticketswap.yml
+++ b/_data/meltano/loaders/target-redshift/ticketswap.yml
@@ -40,13 +40,13 @@ settings:
   kind: integer
   label: Batch Size Rows
   name: batch_size_rows
-- description: Redshift cluster identifier. Note if sqlalchemy_url is set or enable_iam_authentication
+- description: Redshift cluster identifier. Note if enable_iam_authentication
     is false this will be ignored.
   kind: password
   label: Cluster IDentifier
   name: cluster_identifier
   sensitive: true
-- description: Database name. Note if sqlalchemy_url is set this will be ignored.
+- description: Database name.
   kind: string
   label: Database name
   name: dbname
@@ -55,16 +55,8 @@ settings:
   label: Default Target Schema
   name: default_target_schema
   value: $MELTANO_EXTRACT__LOAD_SCHEMA
-- description: Dialect+driver see 
-    https://aws.amazon.com/blogs/big-data/use-the-amazon-redshift-sqlalchemy-dialect-to-interact-with-amazon-redshift.
-    Generally just leave this alone. Note if sqlalchemy_url is set this will be ignored.
-  kind: string
-  label: Dialect+Driver
-  name: dialect+driver
-  value: redshift+redshift_connector
 - description: If true, use temporary credentials 
     (https://docs.aws.amazon.com/redshift/latest/mgmt/generating-iam-credentials-cli-api.html).
-    Note if sqlalchemy_url is set this will be ignored.
   kind: boolean
   label: Enable Iam Authentication
   name: enable_iam_authentication
@@ -92,8 +84,7 @@ settings:
   label: Hard Delete
   name: hard_delete
   value: false
-- description: Hostname for redshift instance. Note if sqlalchemy_url is set this
-    will be ignored.
+- description: Hostname for redshift instance.
   kind: string
   label: Host
   name: host
@@ -112,14 +103,12 @@ settings:
   - label: Overwrite
     value: overwrite
   value: append-only
-- description: Password used to authenticate. Note if sqlalchemy_url is set this will
-    be ignored.
+- description: Password used to authenticate.
   kind: password
   label: Password
   name: password
   sensitive: true
-- description: The port on which redshift is awaiting connection. Note if sqlalchemy_url
-    is set this will be ignored.
+- description: The port on which redshift is awaiting connection. 
   kind: string
   label: Port
   name: port
@@ -144,17 +133,9 @@ settings:
   kind: string
   label: S3 Region
   name: s3_region
-- description: SQLAlchemy connection string. This will override using host, user,
-    password, port, dialect, and all ssl settings. Note that you must escape password
-    special characters properly. See 
-    https://docs.sqlalchemy.org/en/20/core/engines.html#escaping-special-characters-such-as-signs-in-passwords
-  kind: string
-  label: Sqlalchemy URL
-  name: sqlalchemy_url
 - description: Whether or not to use ssl to verify the server's identity. Use ssl_certificate_authority
     and ssl_mode for further customization. To use a client certificate to authenticate
-    yourself to the server, use ssl_client_certificate_enable instead. Note if sqlalchemy_url
-    is set this will be ignored.
+    yourself to the server, use ssl_client_certificate_enable instead. 
   kind: boolean
   label: SSL Enable
   name: ssl_enable
@@ -162,7 +143,7 @@ settings:
 - description: SSL Protection method, see [postgres 
     documentation](https://www.postgresql.org/docs/current/libpq-ssl.html#LIBPQ-SSL-PROTECTION)
     for more information. Must be one of disable, allow, prefer, require, verify-ca,
-    or verify-full. Note if sqlalchemy_url is set this will be ignored.
+    or verify-full.
   kind: string
   label: SSL Mode
   name: ssl_mode
@@ -181,8 +162,7 @@ settings:
   label: Temp Dir
   name: temp_dir
   value: temp
-- description: User name used to authenticate. Note if sqlalchemy_url is set this
-    will be ignored.
+- description: User name used to authenticate.
   kind: string
   label: User
   name: user