Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Revert not working #304

Open
ollyhensby opened this issue Mar 21, 2024 · 1 comment
Open

🐛 Revert not working #304

ollyhensby opened this issue Mar 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ollyhensby
Copy link
Contributor

ollyhensby commented Mar 21, 2024 •
edited
Loading

Describe the bug
Pressing revert does not revert the values correctly.

To Reproduce
Made a change to the slider within a nested object:

Slider is set to 2:
image

Change to 1:
image

Revert but stays at 1:
image

Expected behavior
Expect that by pressing revert, the values will change back to how they were.
@ollyhensby ollyhensby added the bug Something isn't working label Mar 21, 2024
@ollyhensby ollyhensby changed the title 🐛 Revert not working in Nested Objects 🐛 Revert not working Mar 21, 2024
@ollyhensby
Copy link
Contributor Author

I think is because no callable is ever passed to the trait fns_on_revert of WrapSaveButtonBar. Maybe we should pass a default function that performs the revert?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ollyhensby