-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helix 25.01 build fails on Ubuntu 24.04 LTS and older due to Rust Compiler version requirement #14
Comments
I have submitted the Helix 25.01 package for Ubuntu 24.10 and it should be available via my PPA in the next few hours. |
I see 25.01 online on launchpad now. |
Jammy is Ubuntu 22.04, which also have the older Rust compilers and therefore do not work. |
Is it not possible to install a newer version of the rust compiler in the build script? I'm also asking because I'm running on Pop!Os which is still on 22.04 (jammy). In any case, thank you for maintaining this PPA, I understand it completely if maintaining too many versions is too much of a hassle. |
I never built a .deb before, but I looked into it just a little now... Shouldn't it be possible since rustc is only a build-dependency? If it is present on the local machine that builds it. Not sure if the path has to be reexported to the debian/rules file to find it. |
Or this could be a good option!
into |
@janos-r The PPA relies on the Launchpad CI/CD infrastructure to build and provide the Debian package for every Ubuntu version. During this process, it installs dependencies from the control file. However, older Ubuntu versions (before 24.10) have an incompatible Rust compiler version with Helix 25.01. Building the package manually is possible, but I can’t provide it via the PPA as outlined. |
I proposed a PR for generating a .deb to the helix repo. It is not as nice as a PPA, but as you said, PPAs are built directly on Launchpad, I had no idea. That makes PPAs for Helix almost useless with that high rustc version. |
Thanks so much for this awesome contribution to Helix!! I just wanted to share my thoughts on the PPA. I don’t think it’s useless since most users probably aren’t interested in building the package themselves. The PPA gives them an easy way to install the latest Helix version for their Ubuntu version without much hassle. This is similar to what we see with other tools like Neovim. Not every distro gets the latest version due to missing dependencies, but having a PPA makes it easier for users to stay up to date. For example, while Helix 25.01 isn’t available for Ubuntu 24.04, it is for 24.10, and I plan to keep providing packages for newer Ubuntu releases. Thanks again for your work - it really helps make Helix better for everyone! |
If helix continues to use the rust-version flag, it will always be too new for LTS distros. And I would guess that those are the far majority of PPA users. This flag forces the compiler to use the exact version and so it should remain a relatively recent one, to not have a too old compiler as well. It is very unfortunate but I guess there is not a better way how to set a minimal compiler version currently, or at least I don't know. With this PPA, currently at least the latest interim ubuntu release and debian sid are covered. But I don't think many people are using those. Non the less you deserve all the respect for maintaining this ppa up till now and into the future! Of course nobody wants to download a deb manually every release. But there is otherwise currently no package for the far majority of debian/ubuntu based distros. At least helix doesn't release very often. |
Helix does indeed always use the Rust version flag, and since starting this PPA, this is only the second time that a newer version couldn’t be built on an older LTS version. That said, most of last year’s releases were successfully built across a variety of Ubuntu versions. If every new Helix version starts requiring a newer Rust compiler version, then you’re absolutely right - the PPA might lose its usefulness. However, I’d prefer to cross that bridge when we get there rather than abandon it prematurely. And yes, it would be great if the Helix team could provide the Debian package with its own repository :)! Maybe something we could propose with your newest contribution to build the Debian package? |
An hour ago I finished the PR with an updated workflow and fixed an old bug that prevented workflows triggered from PRs to finish. I hope it gets accepted soon ^^ |
The build fails on Ubuntu 24.04 LTS (Noble) with the following error message:
Ubuntu 24.04 LTS provides rustc version 1.75.0, which does not meet the minimum requirement for building
helix-core
. However, the new version can be successfully built on Ubuntu 24.10, as it includes a newer version of rustc.Source: https://launchpadlibrarian.net/768468469/buildlog_ubuntu-noble-amd64.helix_25.01-1~ubuntu24.04~ppa1_BUILDING.txt.gz
The text was updated successfully, but these errors were encountered: