Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to ban/kick Admins (or people with the same or above powerlevel than the bot) #396

Closed
ghost opened this issue Oct 29, 2022 · 2 comments
Labels
T-Enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Oct 29, 2022

Mjolnir currently tries to ban or kick Admins or people with the same PL as the bot, this results in an error and some spam in the coordination room, therefore, I believe that mjolnir should first check if it's capable of banning/kicking the user or not instead of just trying without any checks.

This also happens on other circumstances, when mjolnir tries setting a room ACL when it can't because it doesn't have enough permission.

This could be split into another issue called (Mjolnir should check if it can perform an action before commiting to it).

@bkil
Copy link

bkil commented Oct 29, 2022

Related: #115 #240

@turt2live
Copy link
Member

I'm considering this a loose duplicate of #45

@turt2live turt2live closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants