Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign name to single face from main view #369

Open
DerOetzi opened this issue Nov 2, 2020 · 3 comments
Open

Assign name to single face from main view #369

DerOetzi opened this issue Nov 2, 2020 · 3 comments

Comments

@DerOetzi
Copy link

DerOetzi commented Nov 2, 2020

Hey, Thanks for reporting issues back to Nextcloud Face Recognition. Please, try to complete this report in detail so we can help you easier. 😄

Make sure you read all the documentation, and the FAQ, and that the issue has not been reported before. 😉

Expected behaviour

"There are more persons to recognize" although for persons with a single face. Setting the value for Senisitivity "to high" ends up with lots of mixed groups. Set the value to a lower value would do it for me with new "bye bye new person" features. But Renaming in main view for the faces getting single by this would be very nice.

Actual behaviour

"There are more persons to recognize" dialog only shows up for person having at least 2 or more faces.

@matiasdelellis
Copy link
Owner

Hi @DerOetzi
Thank you for continuing to contribute here.. 😬

The limitation of suggesting only at least two faces is for performance. You could easily double the query size by including the individual faces. On the other hand, it would also be annoying to add 500 names by hand for each single face.

Therefore, the idea is to improve this problem, suggesting the singles faces using something similar to PR #262
that would be done only in the second view of person photos,

Probably, within the current "assign name" dialog, it would only show clusters of more than 5 faces and leave the rest as suggestions for similarity, and it should be much more efficient for the server and also for the users.

@matiasdelellis
Copy link
Owner

p.s: Meanwhile, if it seems important to you, comment on these lines. 😉

https://github.com/matiasdelellis/facerecognition/blob/master/lib/Controller/ClusterController.php#L180-L181

@DerOetzi
Copy link
Author

DerOetzi commented Nov 3, 2020

Thanks for the hint. I think #262 is really the better solution for this, for the first run and in combination you can not remove unwanted faces yet (I do this at the moment by renaming those to "Remove". When you would have the possibility to either assign a name, skip for later (I'm not sure) or Don't ask again (set a not show again flag to person/face) this would be worth to me personally to click through this single faces as well. Maybe a solution would be to reintroduce the show_not_grouped flag to make this a user decision again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants