Minimize themes

[janekolszak]

Hi!
Would you consider minimizing the html/css themes?

For example we could:

• use https://github.com/tdewolff/minify when creating hermes.Hermes
• Create hermes.Hermes in a dedicated function like

config := hermes.Config{
    // Optional Theme
    // Theme: new(Default) 
    Product: hermes.Product{
        // Appears in header & footer of e-mails
        Name: "Hermes",
        Link: "https://example-hermes.com/",
        // Optional product logo
        Logo: "http://www.duchess-france.org/wp-content/uploads/2016/01/gopher.png",
    },
}

h := hermes.New(config)
...

[matcornic]

Hello :)

Minifying would be nice indeed, and I agree that this should be an option.

In your example hermes.Config is the same struct as hermes.Hermes. We could just add a new bool member in the struct for minifying the theme. It would avoid API breaking changes.

Or another (better?) solution is to enhance GenerateHTML function (you won't minify plain text) with new parameter(s). There are solutions for this new parameter to be optional, like the option... syntax, in order to avoid breaking changes.

[janekolszak]

I thought minifying should be done only once, when reading the theme. That's why it needs to be done in the New() function. Running minifier each time we send an email is an overkill.

Changing API won't be a problem - you just need to make a "major" release.