Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make service proxying less confusing #14

Open
mary-ext opened this issue Dec 19, 2024 · 0 comments
Open

Make service proxying less confusing #14

mary-ext opened this issue Dec 19, 2024 · 0 comments
Labels
breaking change Issues that involve doing a breaking change

Comments

@mary-ext
Copy link
Owner

The way service proxying work is confusing, service.type actually refers to the service ID within the DID document, not the service type.

We should either rename type to id and requiring a hash prefix, or go all the way with changing it into something like ${At.Did}#${string}

@mary-ext mary-ext added the breaking change Issues that involve doing a breaking change label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Issues that involve doing a breaking change
Projects
None yet
Development

No branches or pull requests

1 participant