Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: a profile field should be selected by default #8

Open
TJR-ELA opened this issue Mar 6, 2023 · 1 comment
Open

Suggestion: a profile field should be selected by default #8

TJR-ELA opened this issue Mar 6, 2023 · 1 comment

Comments

@TJR-ELA
Copy link

TJR-ELA commented Mar 6, 2023

This is an excellent and much needed plugin to get the detail of scores entered in a marking guide. One suggestion based on my experience:

When installing the plugin none of the profile field settings in /admin/settings.php?section=reportadvancedgrading are selected by default. For me, this resulted in a table with columns out of sync (example: https://cloud.lenguas-vivas.com/index.php/f/95961) which I initially thought was a bug. When any of the profile fields are selected in the settings, the table displays correctly. My suggestion would be for (at least) one of the profile fields to be selected by default to prevent this confusion.

To Reproduce

  1. Install the plugin
  2. Go to an assignment and set up a marking guide.
  3. Mark a students assignment
  4. Select Filter > Marking guide breakdown report
  5. Table is displayed as in the excel example above with row 7 shifted one column to the left

Expected behavior
The student name to appear by default

Desktop:

  • OS: Windows 10 Pro 22H2
  • Browser: Chrome 110.0.5481.178

Moodle:

  • 3.11.8 (Build: 20220711)
  • mysql (5.7.39-42)
@marcusgreen
Copy link
Owner

My apologies for how long it has taken me to respond to this. I believe that the username is selected by default when the plugin is first installed. This is the line where it happens.

['username' => 1],

However I will keep this ticket open with a view to adding code to deal with the situation if no profile field is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants