Issue viewing Rubric flex breakdown report

[Kevin-Hipwell]

Describe the bug
When 'Advanced grading' is set to 'Rubric flex' and you click the 'Rubric breakdown report' tab; you get a blank page.

To Reproduce

1. Create an assignment
2. Set 'Advanced grading' to 'Rubric flex'
3. Click the 'Rubric breakdown report' tab

Expected behavior
Should show report

Screenshots
N/A

Desktop (please complete the following information):

• Ubuntu 20.04.6 LTS
• Chrome
• Moodle 4.1.12

Solution
Remove 'defined('MOODLE_INTERNAL') || die;' From file 'rubref.php'

When removed and you have access there is missing string 'rubrefreportname' for $data['reportname']
I created my own string 'rubrefreportflexname' and used that

[marcusgreen]

Thanks Kevin, this is to acknowledge your creation of the issue. i will get back to you as soon as I can.

[marcusgreen]

I just checked and can confirm I have been testing against the same version of Moodle as you. Hope to get back with more information soon.

[marcusgreen]

Hi kevin
My apologies for the delay, I have been away on business. If you can make a copy of the plugin publicly available on Github, I will create a fork and add in an automated behat test that will check that the report is visible from the appropriate place. The major plus of this is that as new Moodle versions become available the tests will be run.
You can see how I make the change to the ci here

moodle-report_advancedgrading/.github/workflows/moodle-ci.yml

Line 66 in a7b9195

moodle-plugin-ci add-plugin --branch MOODLE_402_STABLE catalyst/moodle-gradingform_rubric_ranges

Where it pulls in the rubric_ranges advanced grading method created by Catalyst NZ

Then I can create a simple behat test like this one
https://github.com/marcusgreen/moodle-report_advancedgrading/blob/advanced_grading_1.0/tests/behat/advancedgrading_guide.feature

So everytime any code is pused to the advanced grading plugin it will check at least that it appears in the menu (which it does for me).

[Kevin-Hipwell]

Hi Marcus,

I have forked you main branch to my public repo https://github.com/Kevin-Hipwell/moodle-report_advancedgrading

Unfortunately I have applied the fix for this issue (30) but also issue (15) #15 so not sure if this messes with things or not.

Please let me know if you need anything else from me.

Regards,
Kevin

[marcusgreen]

Thanks Kevin, I will take a look. I intend doing a relase to the plugins database for 4.5 compatibility in the near future.
Best wishes

[marcusgreen]

Hi Kevin I have removed the internal check as per your repo and added a credti to you in the commit and in the changelog.
https://github.com/marcusgreen/moodle-report_advancedgrading/blob/main/changelog.md
I don't know why it would have worked for me but not for you with that internal check, but it was not present in the matching files for other grading methods (guide, marking etc) so it wasn't doing anything useful.

Your other change looks interesting but I have yet to get around to fully evaluating it.
Can you create a public repo containing rubric flex/refined so when it comes to future updates to this report it will be easy to test against.
Best wishes
Marcus

[Kevin-Hipwell]

Hi Marcus,

Forgive my ignorance; collaborating on projects with github is still quite new to me.
I do not understand why you need me to create a public repo containing rubric flex/refined; but that is no matter; I am not sure where I can find 'rubric flex/refined' to copy into a public repo.
Could you please clarify what you need me to do (perhaps where I can find 'rubric flex/refined') as I would be happy to help by whichever means needed.

Regards,
Kevin

[marcusgreen]

Sorry Kevin, there was a lot of assumed knowledge in my post. Can you email me at marcusavgreen at gmail.com