Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically inherit theme & color style changes from Gedit #37

Open
nekohayo opened this issue Jun 21, 2021 · 4 comments
Open

Automatically inherit theme & color style changes from Gedit #37

nekohayo opened this issue Jun 21, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@nekohayo
Copy link

Kind of a pony wishlist here, but it would be great if this plugin could automatically inherit my Gedit color theme setting (ex: "Oblivion"), and stay connected with a signal/API/dbus/whatever to changes to that setting so that when it is changed in the gedit preferences, it is automatically applied/refreshed in the markdown preview plugin.

One of the reasons I'm asking for this is that I have my own little tool that changes Gedit's color scheme to "Oblivion" at night and "Tango" during daytime :)

@maoschanz maoschanz added the enhancement New feature or request label Jun 21, 2021
@maoschanz
Copy link
Owner

ok you should have say #36 here, because the solution of this color style thing is clearly to replace the "enable css" switch by a bunch of radio buttons:

  • don't add css
  • use css from the gedit color-scheme
  • use a custom css file

then adding some fat colored border-left to the blockquote tags is possible when this 2nd option is chosen

@nekohayo
Copy link
Author

Personally I'm thinking that less options is better and that if possible the app/extension should try to guess what's best, so inherit the theme/style colors from gedit but allow overriding it with CSS if the user really cares. So it becomes just one option: Custom CSS on top of the inherited style, or not. On/Off, basically.

@maoschanz
Copy link
Owner

So if the user doesn't want CSS, they should... override it with an empty file? What a counter-intuitive hack. A group of radio buttons corresponds to a single setting, so it's still one option, and it's less ridiculous.

@nekohayo
Copy link
Author

nekohayo commented Dec 3, 2022

So if the user doesn't want CSS, they should... override it with an empty file?

No, I don't think I have said that, especially not in this way of saying it.


Technically now you don't necessarily need to follow gedit's setting, you could also follow the system one, as nowadays there is also standardized way for your app to authoritatively know (without just trying to "guess" whether the current GTK theme is dark or not) what the user's intent is in terms of light/dark themes, at the system level.

Most applications already support this with GNOME 42+ and Elementary OS 6, even non-purely-GTK applications such as Firefox. I believe lots of applications on KDE support this standard as well.

In this particular case I'm not sure which approach is best: inheriting the color scheme from gedit, or going straight to the source at the system's preference. Gedit hasn't implemented this approach yet.

For apps that offer the user a choice whether to follow the system theme or not, an example of a commonly used UI for this in GTK and GNOME apps is the screenshot you can see here: mjakeman/extension-manager#218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants