Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong price - read please #22

Open
stasdem opened this issue Aug 14, 2017 · 12 comments
Open

Wrong price - read please #22

stasdem opened this issue Aug 14, 2017 · 12 comments

Comments

@stasdem
Copy link

stasdem commented Aug 14, 2017

Hello
It is not the same as issue 18(#18), please read.
Generally you make great program, but still have some bugs, as I think.
1.
On markets where are no volume, spreads can be very big, and these spreads will kill all profit.
So if we want to buy on one exchange and sold on another, we need to check not buy_price on first exchange and sell_price on second, but sell_price on first and buy_price on second. Because sell_price will be our buy price and buy_price will be our sell price.
For example:
http://joxi.ru/8AnWlgvtqy9njr
On this printscreen we are going to buy on Cryptopia for 0.0163 and sell on Bittrex for 0.0236, but when will try to buy on Cryptopia you will see big spread
http://joxi.ru/Rmz5ydWcWMLJ0r
And you will buy for the first sell_price, on this printscreen it is 0.00002292.
2.
http://joxi.ru/vAWM8Q0tkOxlZm
In my opinion you need to change this two prices, because Cryptopia have price 0.0163 and Bittrex 0.0236.
Why there are contrariwise?

Thank you.

@manu354
Copy link
Owner

manu354 commented Aug 15, 2017

See if it's fixed now. If it's not I don't really understand the problem, maybe try explaining it again? Sorry.

@gilrosenthal
Copy link
Contributor

@manu354 I think this can be fixed by accepting my PR of bid/ask. I haven't had any problems with it since

@manu354
Copy link
Owner

manu354 commented Aug 15, 2017

@gilrosenthal oh shit I completely forgot about the prs. Let me get that into a dev branch.

@stasdem
Copy link
Author

stasdem commented Aug 16, 2017

@gilrosenthal Yes, you are right. I meant this, that you use last_price, but you need to use bid and ask prices.

@stasdem
Copy link
Author

stasdem commented Aug 16, 2017

Also I suggest to add variable volume on wich you want to trade. This variable need to be, because when you check bid and ask price you also need to check volume wich you can buy or sell for this price.
And the right price for your volume will be summ of bid or ask prices(wich will give you your volume) divided by quantity of prices.

@chrisiew89
Copy link

Has this been fixed? I also noticed that even though the program shows that there is an arbitrage, the arbitrage is only available when you manage to buy at bid price and sell at ask price. To be able execute the arbitrage, correct way is to be able to buy at ask price and sell at bid price. Hope this explanation helps.

@roko772
Copy link

roko772 commented Oct 5, 2017

any updates?

@manu354
Copy link
Owner

manu354 commented Oct 5, 2017

I'm not working on this project anymore.

@rokcarl
Copy link

rokcarl commented Nov 24, 2017

Are you planning on working on this in the future or is this the end of this repo?

@Cozy35
Copy link

Cozy35 commented Jan 16, 2018

Has anybody been able to rectify the ask/bid vs latest price issue?

@happyjack27
Copy link

happyjack27 commented Jan 16, 2018 via email

@Cozy35
Copy link

Cozy35 commented Jan 16, 2018

What I mean, since the project isn't being developed any further, has anyone attempted to fix the script from last price to either bid or ask where applicable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants