You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The documentation in the file introprog.IO for the parameter fileName is a bit ambiguous. After trying to use this library myself and after reading in the course forum in the channel frågor-och-svar, I’ve come to the conclusion that it probably should be renamed to path or add documentation to explain that it’s the path of the file and not just the file name.
The text was updated successfully, but these errors were encountered:
Yes,file is probably a better param name than fileName. @jos-rosenqvist-3812 What do you think? Maybe this PR #15 with doc improvement helps to clear the ambiguity enough to make it less urgent to change the param name? After all param name changes can break existing client code and requires update of all examples etc...
A global search on fileName (case sensitive, whole word) in the introprog repo gives 158 ! occurences of fileName so this change is heavy and needs some careful reviewing.
The documentation in the file
introprog.IO
for the parameterfileName
is a bit ambiguous. After trying to use this library myself and after reading in the course forum in the channelfrågor-och-svar
, I’ve come to the conclusion that it probably should be renamed to path or add documentation to explain that it’s the path of the file and not just the file name.The text was updated successfully, but these errors were encountered: