You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a couple of points that I'd like to address:
Rename the lib folder to something like utils.
Move the unionConfig handling code from utils to a separate package (or at least a separate folder or file).
Move webpack.config.js along with the parts to a separate package or a separate folder (or even a file, that would be sufficient).
I don't understand the point of having a separate startDevServer.js file, just merge it with the start.js file.
The scripts directory is a mess of multiple types of files. I'd like it to be a directory with the possible entry points for react-union-scripts and nothing else (test, build, start, that's it).
In my react-union-ssr-server package, I would like to use a couple of useful functions from react-union-scripts (namely the CLI getArgValue function), it makes me think whether we should have a react-union-utils or a react-union-cli package – more small packages will lead to looser coupling and more maintainable code.
The code itself is pretty good, but the directory structure needs a major revamp.
The text was updated successfully, but these errors were encountered:
I will look into that. Not everything is priority. We have plans with union-scripts which makes this possible refactor just temporary. But thank you for comments.
Okay, I'll try to stay away from doing any major refactoring in the ssr branch and will only leave comments as to what should be improved so that we don't forget about it.
There are a couple of points that I'd like to address:
lib
folder to something likeutils
.utils
to a separate package (or at least a separate folder or file).webpack.config.js
along with the parts to a separate package or a separate folder (or even a file, that would be sufficient).startDevServer.js
file, just merge it with thestart.js
file.scripts
directory is a mess of multiple types of files. I'd like it to be a directory with the possible entry points for react-union-scripts and nothing else (test, build, start, that's it).The code itself is pretty good, but the directory structure needs a major revamp.
The text was updated successfully, but these errors were encountered: