Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not enough contrast. #4

Open
rweichler opened this issue Aug 25, 2013 · 3 comments
Open

Not enough contrast. #4

rweichler opened this issue Aug 25, 2013 · 3 comments
Assignees
Labels

Comments

@rweichler
Copy link

This didn't seem to be a problem in the commits around February, but now there is a pretty huge problem with the contrast between the text colors and the background color.

Here are some examples. Title/controls are PrimaryTextColor, album/artist are SecondaryTextColor:
    

Also note specifically in Dr. Dre's 2001 and Immortal Technique's Peruvian Cocaine, BackgroundColor should be #000000 and #FFFFFF respectively, but it seems like you just took the average color of the entire image instead of just sampling the edges. It's kind of hard to tell, but the BackgroundColor of 2001 is actually a very dark green.

Also note how the first image is basically completely black, and the text colors don't default to something like white.

Also, these are just extraneous circumstances, most of the colors that get picked are REALLY good. Props.

I'll try and see if I can do anything about this on my end, but I thought I should let you know :)

@luisespinoza
Copy link
Owner

Thanks for the feedback @rweichler . I will work on this as soon as possible.

@ghost ghost assigned luisespinoza Aug 26, 2013
@runmad
Copy link

runmad commented Mar 14, 2014

Just wanted to add some feedback on this too... Love the library, super fast and smooth. But I would agree that secondary colour is always either white or black.

The backgroundColor property and the primary text color property seem to be fine.

I have compared it with https://github.com/panicinc/ColorArt which seems to have a few more properties, but also returns a number of colors that are a bit more varied. For example:

screen shot 2014-03-14 at 4 08 21 pm

Any updates since 7 months ago when there was last activity in this Github issue? Thanks!

@faceleg
Copy link

faceleg commented Mar 24, 2015

Is this still maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants