Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Create static inputs #92

Closed
3 tasks
joeflack4 opened this issue Oct 1, 2024 · 2 comments
Closed
3 tasks

Tests: Create static inputs #92

joeflack4 opened this issue Oct 1, 2024 · 2 comments
Assignees

Comments

@joeflack4
Copy link
Collaborator

joeflack4 commented Oct 1, 2024

Overview

Update 2024/12: We've determined that --fast-run is deterministic, and have instead tweaked that to be more thorough, and are using that instead of this. Static inputs would be nicer, but it is not so important now.

Would be nice to have alternative variations for all test input files. These should be smaller so that tests run faster. The data should also be synthetic to avoid any licensing issues.

Sub-tasks

  • 1. Simple inputs: Create synthetic test inputs that have a small number of rows.
  • 2. Config: Set up so that when test is run, it uses these inputs instead of what's listed in the comploinc_config.yaml
  • 3. Updated inputs: Upgrade inputs for internal consistency

3. Upgrade inputs for internal consistency

Ideally, the synthetic terms and properties between the files should/would be linked so that the output makes more sense and more sensible tests can be run. What I mean by this is that the synthetic part terms created in one file should be shown in other files, synthetic LOINC terms should appear in the synthetic LOINC release, as well as the LOINC tree, etc. SNOMED-Ontology synthetic terms should be found both in synthetic SNOMED and LOINC. This might be a tall order though; so maybe could leave this requirement out for the first iteration.

@joeflack4 joeflack4 self-assigned this Oct 1, 2024
@github-project-automation github-project-automation bot moved this to 1. Backlog in CompLOINC Oct 1, 2024
@joeflack4
Copy link
Collaborator Author

joeflack4 commented Nov 13, 2024

Another reason to do this is that this it might be the best way to fix:

@joeflack4
Copy link
Collaborator Author

Update 2024/12: We've determined that --fast-run is deterministic, and have instead tweaked that to be more thorough, and are using that instead of this. Static inputs would be nicer, but it is not so important now.

@joeflack4 joeflack4 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2024
@github-project-automation github-project-automation bot moved this from 1. Backlog to 4. Done in CompLOINC Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 4. Done
Development

No branches or pull requests

1 participant