Fix @fluxStyles rendering
#933
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly render the stylesheet so that the $versionHash and $nonce values actually appear instead of just showing the PHP variable.
joshhanley
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
@sevenpixels thanks for the PR! @calebporzio I've pulled this and checked that it's all working as expected, so it's good to merge.
The problem is that when I updated the Flux Styles in PR #899 I didn't change to string interpolation for the $versionHash and $nonce.
So this PR fixes that, so everything works normally again.
|
Just noticed this too, also tested the fix here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly render the stylesheet so that the $versionHash and $nonce values actually appear instead of just showing the PHP variables.
Fixes #932