From 4a0126fcad46cec8f3812aef8d2acc294f873f4d Mon Sep 17 00:00:00 2001 From: TonySpegel Date: Tue, 8 Jun 2021 15:48:50 +0200 Subject: [PATCH] Include build-script to make use of rollup config As there already is a rollup.config.js included in this project I expected that there would be a build-script too which makes use of this file. So far rollup is only used for the docs:build and checksize task. Including this new script would help beginners to make it more easier to actually use the component later on. Throughout the docs roolup is mentioned first when talking about building your component so I think it's fair to include a step to build the component. An alternative would be to also include a webpack config and also step for that but I'd argument for rollup to keep the starter project simple --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index ab02c6bd..f23bf98c 100644 --- a/package.json +++ b/package.json @@ -9,6 +9,7 @@ "scripts": { "build": "tsc", "build:watch": "tsc --watch", + "build:element": "npm run build && rollup -c", "clean": "rimraf my-element.{d.ts,d.ts.map,js,js.map} test/my-element.{d.ts,d.ts.map,js,js.map} test/my-element_test.{d.ts,d.ts.map,js,js.map}", "lint": "npm run lint:lit-analyzer && npm run lint:eslint", "lint:eslint": "eslint 'src/**/*.ts'",