-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kraken230 firmware 2 image support #692
Kraken230 firmware 2 image support #692
Conversation
Set image sending twice to avoid no change after USB device initialization
So I wrote the solution to send the image to the AIO LCD. The manufacturer software sends it twice too. BTW I don't know why the commits went from my second account that I don't use :), probably git config thing |
Also:
Thanks! |
I added potential fix for |
Anything else I need to do? |
@aleksamagicka @jonasmalacofilho please tell me what I need to do to merge this change? |
I don't know if I'm supposed to do that, but I checked all items in the task, since LGTM received. |
No need to select things that are not applicable to your PR, for example, updating the man pages if it's not needed (and I don't think it is, here). |
So edit PR and remove items now? |
I don't think there's a hard and fast rule... I just leave them unchecked if they do not apply. |
Is this waiting for the comment on line 205 of the md guide to be removed, or trying to find a solution to the double image send? Looking forward to this getting merged to main 🙏 |
I think we are waiting for @jonasmalacofilho review? |
LGTM, thanks! |
Added ability to set images for Kraken with firmware version 2
Fixes: #631
Closes:
Related:
Checklist:
docs/*guide.md
device guides, with "new/changed in" notesliquidctl.8
Linux/Unix/Mac OS man pagedocs/developer/protocol