Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel/kvm tests are missing a 'needs_drivers' in their test definition #1219

Open
cdm-work opened this issue Jan 23, 2025 · 1 comment
Open

Comments

@cdm-work
Copy link

All of the KVM tests need the 'kvm' driver to be present (and loaded) in order for the tests to run successfully. This would normally be accomplished by having the following present in the struct tst-test test definition for each testcase:

static struct tst_test test = {
...
      .needs_drivers = (const char *const []) {
              "kvm",
              NULL
      },
...
};

None of the KVM testcases have this. This means that rather than skipping the test on a system where 'kvm' is not present, the tests are run and report a BROK instead.

As I hinted, it does seem that KVM can be present on a system but not loaded. As a result, tests still run would pass the above check, but they would still report BROK. However, I suspect that this particular additional issue is not as relevant to the project.

@pevik
Copy link
Member

pevik commented Jan 24, 2025

LGTM, would you mind to send a patch to our mailing list or a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants