Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--version #40

Open
marado opened this issue Apr 3, 2023 · 2 comments · May be fixed by #90
Open

--version #40

marado opened this issue Apr 3, 2023 · 2 comments · May be fixed by #90

Comments

@marado
Copy link

marado commented Apr 3, 2023

It would be nice to have a --version on this tool, specially if it is one that uses uses the git hash when it is a development version, so we can easilly pinpoint exactly what is on the qdl binary being used. Bonus points if --debug by default starts by outputing the version, so qdl logs will have that info.

@ljkeller
Copy link

Seeing as qdl flashes seem to occasionally fail based upon the version of QDL used, I seriously agree agree with this request. Would this be something any user could implement?

@ndechesne
Copy link
Contributor

Yes, it makes sense. And we don't want that to be a pain to maintain in the repo, so ideally we could create a version string with "git describe --dirty --always --tags". We will check with our internal tools team who builds QDL for Windows and Linux (on the Qualcomm Software Center) to make sure that they are indeed using a git workspace in their build env, so that this would work for them too. The implementation will then be straightforward

@ndechesne ndechesne linked a pull request Jan 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants