From 798fc17fcc1927180fcbd8b97ada4d117e202f1c Mon Sep 17 00:00:00 2001 From: Bohan Yang Date: Tue, 19 Dec 2023 14:58:16 -0800 Subject: [PATCH] move the log about merged uri properties version --- .../d2/balancer/properties/UriPropertiesMerger.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/d2/src/main/java/com/linkedin/d2/balancer/properties/UriPropertiesMerger.java b/d2/src/main/java/com/linkedin/d2/balancer/properties/UriPropertiesMerger.java index 45664af56e..06340c6808 100644 --- a/d2/src/main/java/com/linkedin/d2/balancer/properties/UriPropertiesMerger.java +++ b/d2/src/main/java/com/linkedin/d2/balancer/properties/UriPropertiesMerger.java @@ -45,10 +45,6 @@ public UriProperties merge(String propertyName, Collection proper { propertyVersion = property.getVersion(); maxVersion = Long.max(maxVersion, propertyVersion); - if (maxVersion == -1) - { - _log.warn("Uri properties has invalid version: {}. It should be > -1.", propertyVersion); - } for (Map.Entry> entry : property.getPartitionDesc().entrySet()) { partitionData.put(entry.getKey(), entry.getValue()); @@ -59,6 +55,10 @@ public UriProperties merge(String propertyName, Collection proper } } + if (maxVersion == -1) + { + _log.warn("Merged Uri properties has invalid version -1. It should be > -1."); + } return new UriProperties(clusterName, partitionData, uriSpecificProperties, maxVersion); }