Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov CI action should install package in dev mode #381

Closed
hombit opened this issue Feb 5, 2024 · 3 comments · Fixed by #391
Closed

Codecov CI action should install package in dev mode #381

hombit opened this issue Feb 5, 2024 · 3 comments · Fixed by #391
Assignees

Comments

@hombit
Copy link
Contributor

hombit commented Feb 5, 2024

In current main, codecov action installs the user's package with pip install .. It looks like sometimes it may cause some issues with pytest, see this failed action (corresponding workflow):
https://github.com/lincc-frameworks/pandas-ts/actions/runs/7785027534/job/21226701366?pr=20

I'm not sure why it happens, it may be issue with my project. Shallow googling showed that maybe it is because pytest is unhappy with pip install which may leave some artifacts in the working directory. I solved the issue on my side changing both coe installation lines to

pip install -e .
pip install -e .[dev]
@hombit
Copy link
Contributor Author

hombit commented Feb 6, 2024

@delucchi-cmu
Copy link
Contributor

Based on my (very limited) experimentation, this looks more related to removing the tests argument to pytest, which YOU ASKED FOR.

#249

https://github.com/lincc-frameworks/pandas-ts/pull/24/files

@hombit
Copy link
Contributor Author

hombit commented Feb 6, 2024

I think i have all these troubles because I added doctests, so no pytest is asked to look into both src/ and tests/ so it imports the code twice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants