You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// AmtPaid is the final amount that we ultimately accepted for pay for
// this invoice. We specify this value independently as it's possible
// that the invoice originally didn't specify an amount, or the sender
// overpaid.
AmtPaid lnwire.MilliSatoshi
We need to make the description more clear what AmtPaid really means especially when it comes to HoldInvoice which can cancel the HTLC which right now results in the AmtPaid increasing even though the HTLC might have been canceled. So either we clarify the description or we do not increase the Amt if an HTLC is just in the Accepted state.
Came up during the development of the invoice migration PR (#8831).
An invoice has an
AmtPaid
field when represented on disk and also in memory:lnd/channeldb/migration12/invoices.go
Lines 144 to 148 in 1f20bd3
We need to make the description more clear what
AmtPaid
really means especially when it comes to HoldInvoice which can cancel the HTLC which right now results in the AmtPaid increasing even though the HTLC might have been canceled. So either we clarify the description or we do not increase the Amt if an HTLC is just in theAccepted
state.Example:
or in case it was just accepted:
The text was updated successfully, but these errors were encountered: