Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: EstimateRouteFee alters the destination for public nodes leading to inaccurate estimations. #9431

Open
ziggie1984 opened this issue Jan 21, 2025 · 0 comments · May be fixed by #9433
Open
Assignees
Labels
bug Unintended code behaviour path finding
Milestone

Comments

@ziggie1984
Copy link
Collaborator

Some lightning implementations (CLN) add routehints to the invoice to signal where they have liquidity on the incoming channel. Our current estimateroutefee rpc call will alter the route and try to send a payment to the pre-last hop, messing up the fee-estimation.

Not 100% sure what was the main assumption behind the isLSP heuristic we have in the code, but we need to make sure that public node destinations are excluded and probed directly instead of altering the route.

@ziggie1984 ziggie1984 added bug Unintended code behaviour path finding labels Jan 21, 2025
@saubyk saubyk added this to the v0.19.0 milestone Jan 22, 2025
@saubyk saubyk added this to lnd v0.19 Jan 22, 2025
@saubyk saubyk moved this to Todo in lnd v0.19 Jan 22, 2025
@saubyk saubyk moved this from Todo to In Progress in lnd v0.19 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unintended code behaviour path finding
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants