Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #947: Menu burger modifications #997

Open
wants to merge 7 commits into
base: testnet
Choose a base branch
from

Conversation

BlessingEmejulu
Copy link

@BlessingEmejulu BlessingEmejulu commented Jan 26, 2025

close: #947
This pull request introduces updates to the desktopNav.tsx file, including integrating TwitterIcon, DiscordIcon, and GithubIcon components with dimensions and colours aligned to design specifications. The desktop navigation container's styling was also updated to include a new background colour and border colour to match the Figma design. Testing verified that the icons display correctly with the specified styles and that the navigation container's updated background and border colours align with the design requirements. Screenshots demonstrating these changes are included.

image

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced custom icon components for Twitter, Discord, and GitHub
  • Improvements

    • Enhanced code robustness with optional chaining for DOM interactions
    • Updated icon designs with new SVG implementations
  • Dependency Updates

    • Upgraded several key dependencies, including Next.js, Emotion React, and Personhood SDK
  • Style Changes

    • Refined desktop navigation styling with updated color variables and box shadow
    • Adjusted color schemes and hover effects in navigation components

Copy link

vercel bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-starknet-id ❌ Failed (Inspect) Jan 26, 2025 10:52am

Copy link

vercel bot commented Jan 26, 2025

@BlessingEmejulu is attempting to deploy a commit to the LFG Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jan 26, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This pull request involves updates to multiple components in the UI, focusing on icon implementations, event listener safety, and styling refinements. The changes include replacing Font Awesome icons with custom icon components in the desktop navigation, modifying SVG icon designs for Discord, GitHub, and Twitter icons, adding optional chaining for DOM interactions, and updating dependency versions in the package configuration.

Changes

File Change Summary
components/UI/desktopNav.tsx Replaced Font Awesome icons with custom icon components, added optional chaining for DOM interactions
components/UI/iconsComponents/icons/discordIcon.tsx Completely redesigned SVG icon with new viewBox, path, and fill color
components/UI/iconsComponents/icons/githubIcon.tsx Overhauled icon rendering with fixed dimensions, new clip path, and complex SVG structure
components/UI/iconsComponents/icons/twitterIcon.tsx Modified SVG viewBox, path data, and fill color
components/UI/searchBar.tsx Added optional chaining for document event listeners
package.json Updated dependency versions for several packages
styles/components/desktopNav.module.css Refined styling using CSS variables, updated background and border colors

Possibly related issues

Possibly related PRs

Suggested labels

❌ Change request

Suggested reviewers

  • Marchand-Nicolas

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🧹 Nitpick comments (3)
components/UI/iconsComponents/icons/twitterIcon.tsx (1)

8-10: Maintain consistent viewBox dimensions across icons.

The viewBox dimensions (26x23) differ from Discord and GitHub icons (28x28), which may cause inconsistent scaling.

-      viewBox="0 0 26 23"
+      viewBox="0 0 28 28"
components/UI/desktopNav.tsx (2)

19-22: Consider using a constant for the burger menu ID.

The hardcoded ID "burger" should be defined as a constant to prevent typos and improve maintainability.

+const BURGER_MENU_ID = "burger" as const;
+
 const DesktopNav: FunctionComponent<DesktopNavProps> = ({ close }) => {
   // ...
-      const burger = document?.getElementById("burger");
+      const burger = document?.getElementById(BURGER_MENU_ID);

77-77: Use consistent types for icon dimensions.

The width prop is passed as a string "23" but should be a number for consistency. Also, consider using the same dimensions as the icon's viewBox (28) for optimal rendering.

-            <TwitterIcon width="23" color="black" />
+            <TwitterIcon width={28} color="black" />

-            <DiscordIcon width="23" color="#5865F2" />
+            <DiscordIcon width={28} color="#5865F2" />

-            <GitHubIcon width="23" color="black" />
+            <GitHubIcon width={28} color="black" />

Also applies to: 82-82, 87-87

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9937c82 and 4a9a2e6.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (7)
  • components/UI/desktopNav.tsx (3 hunks)
  • components/UI/iconsComponents/icons/discordIcon.tsx (1 hunks)
  • components/UI/iconsComponents/icons/githubIcon.tsx (1 hunks)
  • components/UI/iconsComponents/icons/twitterIcon.tsx (1 hunks)
  • components/UI/searchBar.tsx (1 hunks)
  • package.json (2 hunks)
  • styles/components/desktopNav.module.css (2 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
components/UI/searchBar.tsx

[error] 142-142: Expected an expression, or an assignment but instead found '.'.

Expected an expression, or an assignment here.

(parse)

styles/components/desktopNav.module.css

[error] 5-5: Expected a declaration, or an at rule but instead found ';'.

Expected a declaration, or an at rule here.

(parse)

🔇 Additional comments (6)
components/UI/searchBar.tsx (1)

140-140: LGTM! Good defensive programming practice.

The addition of optional chaining for document access is a good practice for SSR compatibility and runtime safety.

components/UI/desktopNav.tsx (1)

25-28: Consider fallback for document undefined.

The optional chaining might hide real issues. Consider adding a development-time warning when document is undefined.

+    if (typeof document === "undefined") {
+      console.warn("DesktopNav: document is undefined, event listeners won't work");
+      return;
+    }
-    document?.addEventListener("mousedown", handleClickOutside);
+    document.addEventListener("mousedown", handleClickOutside);
     return () => {
-      document?.removeEventListener("mousedown", handleClickOutside);
+      document.removeEventListener("mousedown", handleClickOutside);
     };
✅ Verification successful

Add development-time warning for document undefined

The review comment is valid. Since this is a Next.js application with SSR capabilities, adding the development-time warning is a good practice. The suggested code changes will help catch potential SSR-related issues during development while ensuring proper cleanup of event listeners.

The proposed solution:

  1. Early check for document undefined with a warning
  2. Safe access to document APIs after the check
  3. Proper cleanup in the effect's cleanup function

The suggested code changes in the review comment are appropriate and should be implemented as shown.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the component is used in SSR context
rg -l "getServerSideProps|getInitialProps" . | grep -v "node_modules"

Length of output: 69


Script:

#!/bin/bash
# Check if it's a Next.js project and look for SSR indicators
echo "=== Checking for Next.js configuration ==="
fd "next.config" --type f

echo -e "\n=== Checking for pages directory (Next.js SSR) ==="
fd "^pages$" --type d

echo -e "\n=== Examining document usage patterns ==="
rg "document\?" -A 2 -B 2

echo -e "\n=== Looking at the full component context ==="
cat components/UI/desktopNav.tsx

Length of output: 5378

styles/components/desktopNav.module.css (2)

46-46: LGTM: Color variable update aligns with design system.

The hover state color has been updated to use the design system variable.


9-12: 🛠️ Refactor suggestion

Remove duplicate box-shadow property.

The box-shadow property is declared twice with the same value.

  box-shadow: 0px 2px 30px 0px rgba(0, 0, 0, 0.06);
  border: 1px solid var(--Colors-Content-Grey-200, rgba(205, 204, 204, 1));
  /* border: 1px solid var(--light-tertiary-300, #cccccc); */
  /* background: var(--background-light, #fffcf8); */
  /* Small Shadow */
- box-shadow: 0px 2px 30px 0px rgba(0, 0, 0, 0.06);

Likely invalid or redundant comment.

package.json (2)

13-13: LGTM: Minor version updates for dependencies.

The updates to @anima-protocol/personhood-sdk-react and @emotion/react are minor version bumps that should maintain backward compatibility.

Also applies to: 15-15


34-34: Verify Next.js v15 upgrade impact.

The upgrade from Next.js 14 to 15 is a major version change that might introduce breaking changes. Please ensure:

  1. All Next.js features used in the codebase are compatible with v15
  2. The application has been thoroughly tested with the new version
  3. The upgrade follows the official migration guide

Run this script to check for potential breaking changes:

Also applies to: 40-40

✅ Verification successful

Next.js v15 upgrade appears safe to proceed

The codebase uses the Pages Router pattern which maintains backward compatibility in Next.js 15. No high-risk patterns or deprecated features were detected in the current implementation.

  • Verify Node.js version meets Next.js 15 requirements (Node.js 18.17 or later)
  • Test Image Component usage if present
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for Next.js specific patterns that might be affected by v15 upgrade

# Search for Next.js imports and usage
echo "Checking Next.js imports and usage patterns..."
rg "from 'next/" -A 2

# Search for potential breaking patterns (examples from Next.js changelog)
echo "Checking for potentially affected patterns..."
rg "getInitialProps|getServerSideProps|getStaticProps|getStaticPaths"

Length of output: 302


Script:

#!/bin/bash
# Verify repository content and Next.js usage

# Check if repository is properly cloned
echo "Checking repository content..."
ls -la

# Look for Next.js configuration and structure
echo -e "\nChecking Next.js files and structure..."
fd -t f "^next\.config\.(js|mjs|ts)$"
fd -t d "^(app|pages)$"

# Broader search for Next.js patterns
echo -e "\nChecking Next.js imports and usage (broader patterns)..."
rg "from ['\"]next" -l
rg "import.*from ['\"]next" -l

# Check for routing and API patterns
echo -e "\nChecking routing and API patterns..."
fd -t f "^route\.(js|ts)$"
fd -t f "^page\.(js|tsx|ts)$"
fd -t f "^layout\.(js|tsx|ts)$"

Length of output: 5708

return () => {
document.removeEventListener("mousedown", handleClickOutside);
document? .removeEventListener("mousedown", handleClickOutside);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix syntax error in optional chaining.

There's an invalid space between document? and .removeEventListener which will cause a syntax error.

Apply this fix:

-      document? .removeEventListener("mousedown", handleClickOutside);
+      document?.removeEventListener("mousedown", handleClickOutside);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
document? .removeEventListener("mousedown", handleClickOutside);
document?.removeEventListener("mousedown", handleClickOutside);
🧰 Tools
🪛 Biome (1.9.4)

[error] 142-142: Expected an expression, or an assignment but instead found '.'.

Expected an expression, or an assignment here.

(parse)

Comment on lines +13 to +14
d="M20.0437 0.625H23.801L15.5935 10.0295L25.25 22.829H17.69L11.7645 15.0677L4.992 22.829H1.23125L10.0092 12.7665L0.75 0.62675H8.5025L13.8505 7.7195L20.0437 0.625ZM18.7225 20.575H20.805L7.365 2.76175H5.132L18.7225 20.575Z"
fill="black"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix color override in SVG path.

The hardcoded fill="black" in the path overrides the color prop passed to the component, making the color customization ineffective.

-        fill="black"
+        fill="currentColor"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
d="M20.0437 0.625H23.801L15.5935 10.0295L25.25 22.829H17.69L11.7645 15.0677L4.992 22.829H1.23125L10.0092 12.7665L0.75 0.62675H8.5025L13.8505 7.7195L20.0437 0.625ZM18.7225 20.575H20.805L7.365 2.76175H5.132L18.7225 20.575Z"
fill="black"
d="M20.0437 0.625H23.801L15.5935 10.0295L25.25 22.829H17.69L11.7645 15.0677L4.992 22.829H1.23125L10.0092 12.7665L0.75 0.62675H8.5025L13.8505 7.7195L20.0437 0.625ZM18.7225 20.575H20.805L7.365 2.76175H5.132L18.7225 20.575Z"
fill="currentColor"

Comment on lines +13 to +14
d="M22.5038 5.96338C20.8971 5.21161 19.1973 4.67744 17.4493 4.375C17.2316 4.76863 16.9772 5.29806 16.8018 5.71925C14.9172 5.43584 13.0499 5.43584 11.2 5.71925C11.0247 5.29815 10.7646 4.76863 10.5448 4.375C8.79517 4.67757 7.09392 5.2131 5.48643 5.96731C2.28765 10.8012 1.42049 15.5148 1.85402 20.1618C3.97566 21.7462 6.03175 22.7086 8.05319 23.3385C8.5556 22.6476 8.9997 21.9162 9.38088 21.1518C8.65509 20.8754 7.9554 20.5349 7.29015 20.1342C7.4652 20.0045 7.63615 19.8692 7.80274 19.7287C11.8339 21.6143 16.2141 21.6143 20.1972 19.7287C20.3645 19.8683 20.5354 20.0035 20.7097 20.1342C20.0434 20.536 19.3424 20.8772 18.6152 21.1538C18.9986 21.9213 19.4419 22.6534 19.9429 23.3404C21.9662 22.7107 24.0242 21.7482 26.1459 20.1618C26.6546 14.7749 25.2769 10.1045 22.5038 5.96338ZM9.93012 17.304C8.71995 17.304 7.72751 16.1742 7.72751 14.7985C7.72751 13.4228 8.6988 12.2911 9.93012 12.2911C11.1614 12.2911 12.1539 13.4208 12.1327 14.7985C12.1346 16.1742 11.1615 17.304 9.93012 17.304ZM18.0698 17.304C16.8596 17.304 15.8673 16.1742 15.8673 14.7985C15.8673 13.4228 16.8384 12.2911 18.0698 12.2911C19.3012 12.2911 20.2935 13.4208 20.2724 14.7985C20.2724 16.1742 19.3012 17.304 18.0698 17.304Z"
fill="#5865F2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix color override in SVG path.

The hardcoded fill="#5865F2" in the path overrides the color prop passed to the component, making the color customization ineffective.

-        fill="#5865F2"
+        fill="currentColor"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
d="M22.5038 5.96338C20.8971 5.21161 19.1973 4.67744 17.4493 4.375C17.2316 4.76863 16.9772 5.29806 16.8018 5.71925C14.9172 5.43584 13.0499 5.43584 11.2 5.71925C11.0247 5.29815 10.7646 4.76863 10.5448 4.375C8.79517 4.67757 7.09392 5.2131 5.48643 5.96731C2.28765 10.8012 1.42049 15.5148 1.85402 20.1618C3.97566 21.7462 6.03175 22.7086 8.05319 23.3385C8.5556 22.6476 8.9997 21.9162 9.38088 21.1518C8.65509 20.8754 7.9554 20.5349 7.29015 20.1342C7.4652 20.0045 7.63615 19.8692 7.80274 19.7287C11.8339 21.6143 16.2141 21.6143 20.1972 19.7287C20.3645 19.8683 20.5354 20.0035 20.7097 20.1342C20.0434 20.536 19.3424 20.8772 18.6152 21.1538C18.9986 21.9213 19.4419 22.6534 19.9429 23.3404C21.9662 22.7107 24.0242 21.7482 26.1459 20.1618C26.6546 14.7749 25.2769 10.1045 22.5038 5.96338ZM9.93012 17.304C8.71995 17.304 7.72751 16.1742 7.72751 14.7985C7.72751 13.4228 8.6988 12.2911 9.93012 12.2911C11.1614 12.2911 12.1539 13.4208 12.1327 14.7985C12.1346 16.1742 11.1615 17.304 9.93012 17.304ZM18.0698 17.304C16.8596 17.304 15.8673 16.1742 15.8673 14.7985C15.8673 13.4228 16.8384 12.2911 18.0698 12.2911C19.3012 12.2911 20.2935 13.4208 20.2724 14.7985C20.2724 16.1742 19.3012 17.304 18.0698 17.304Z"
fill="#5865F2"
d="M22.5038 5.96338C20.8971 5.21161 19.1973 4.67744 17.4493 4.375C17.2316 4.76863 16.9772 5.29806 16.8018 5.71925C14.9172 5.43584 13.0499 5.43584 11.2 5.71925C11.0247 5.29815 10.7646 4.76863 10.5448 4.375C8.79517 4.67757 7.09392 5.2131 5.48643 5.96731C2.28765 10.8012 1.42049 15.5148 1.85402 20.1618C3.97566 21.7462 6.03175 22.7086 8.05319 23.3385C8.5556 22.6476 8.9997 21.9162 9.38088 21.1518C8.65509 20.8754 7.9554 20.5349 7.29015 20.1342C7.4652 20.0045 7.63615 19.8692 7.80274 19.7287C11.8339 21.6143 16.2141 21.6143 20.1972 19.7287C20.3645 19.8683 20.5354 20.0035 20.7097 20.1342C20.0434 20.536 19.3424 20.8772 18.6152 21.1538C18.9986 21.9213 19.4419 22.6534 19.9429 23.3404C21.9662 22.7107 24.0242 21.7482 26.1459 20.1618C26.6546 14.7749 25.2769 10.1045 22.5038 5.96338ZM9.93012 17.304C8.71995 17.304 7.72751 16.1742 7.72751 14.7985C7.72751 13.4228 8.6988 12.2911 9.93012 12.2911C11.1614 12.2911 12.1539 13.4208 12.1327 14.7985C12.1346 16.1742 11.1615 17.304 9.93012 17.304ZM18.0698 17.304C16.8596 17.304 15.8673 16.1742 15.8673 14.7985C15.8673 13.4228 16.8384 12.2911 18.0698 12.2911C19.3012 12.2911 20.2935 13.4208 20.2724 14.7985C20.2724 16.1742 19.3012 17.304 18.0698 17.304Z"
fill="currentColor"

Comment on lines +6 to +7
width="28"
height="28"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Use dynamic width/height from props.

The hardcoded dimensions prevent the icon from being resized through props.

-      width="28"
-      height="28"
+      width={width}
+      height={width}

Committable suggestion skipped: line range outside the PR's diff.

Comment on lines +4 to +5
background: var(--Colors-Content-Grey-100, hsla(0, 7%, 97%, 1));
;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix syntax error: Remove trailing semicolon.

There's a syntax error in the CSS due to an extra semicolon on line 5.

  background: var(--Colors-Content-Grey-100, hsla(0, 7%, 97%, 1));
- ;
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
background: var(--Colors-Content-Grey-100, hsla(0, 7%, 97%, 1));
;
background: var(--Colors-Content-Grey-100, hsla(0, 7%, 97%, 1));
🧰 Tools
🪛 Biome (1.9.4)

[error] 5-5: Expected a declaration, or an at rule but instead found ';'.

Expected a declaration, or an at rule here.

(parse)

Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments made by the AI

Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it doesn't build...
image
Please take the necessary time to check everything works before submitting.
You can use npm run build

@Marchand-Nicolas Marchand-Nicolas added the ❌ Change request Change requested from reviewer label Jan 26, 2025
Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change the links as on figma. I see on your screenshot you kept 7 links, but on figma there are only 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌ Change request Change requested from reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu burger modifications
2 participants