Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddplugin: get_netrc_auth needs to be deprecated and replaced. #63

Open
leamas opened this issue Apr 5, 2022 · 0 comments
Open

ddplugin: get_netrc_auth needs to be deprecated and replaced. #63

leamas opened this issue Apr 5, 2022 · 0 comments

Comments

@leamas
Copy link
Owner

leamas commented Apr 5, 2022

The get_netrc_auth() method is not fully compatible with the new authentication plugin scheme since it does not have any information whatsoever about which plugin to use.

Current code uses a global which is not that satisfactory. OTOH, the function is part of the interface which should be kept stable, so it cannot just be changed or removed. This means that while adding new methods is fine and probably what should be done, the current broken interface should be kept for now.

And hence the pesky global.

leamas pushed a commit that referenced this issue Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant