Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build dev branch - Dependency conflict #11622

Closed
opichon opened this issue Jan 10, 2025 · 1 comment
Closed

Cannot build dev branch - Dependency conflict #11622

opichon opened this issue Jan 10, 2025 · 1 comment
Labels
bug It's a bug

Comments

@opichon
Copy link

opichon commented Jan 10, 2025

Operating system

macOS

Joplin version

dev

Desktop version info

n/a

Current behaviour

running npm install on dev branch breaks with the following error message:

│➜  joplin git:(dev) npm install                                                                     │
│npm error code ERESOLVE                                                                             │
│npm error ERESOLVE unable to resolve dependency tree                                                │
│npm error                                                                                           │
│npm error While resolving: @joplin/[email protected]                                               │
│npm error Found: [email protected]                                                                       │
│npm error node_modules/react                                                                        │
│npm error   react@"18.3.1" from @joplin/[email protected]                                          │
│npm error   packages/app-desktop                                                                    │
│npm error     @joplin/[email protected]                                                            │
│npm error     node_modules/@joplin/app-desktop                                                      │
│npm error       workspace packages/app-desktop from the root project                                │
│npm error                                                                                           │
│npm error Could not resolve dependency:                                                             │
│npm error peer react@"^16.9.0 || ^17.0.0" from @testing-library/[email protected]                   │
│npm error node_modules/@testing-library/react-hooks                                                 │
│npm error   dev @testing-library/react-hooks@"8.0.1" from @joplin/[email protected]                │
│npm error   packages/app-desktop                                                                    │
│npm error     @joplin/[email protected]                                                            │
│npm error     node_modules/@joplin/app-desktop                                                      │
│npm error       workspace packages/app-desktop from the root project                                │
│npm error                                                                                           │
│npm error Fix the upstream dependency conflict, or retry                                            │
│npm error this command with --force or --legacy-peer-deps                                           │
│npm error to accept an incorrect (and potentially broken) dependency resolution.                    │
│npm error                                                                                           │
│npm error                                                                                           │
│npm error For a full report see:                                                                    │
│npm error /Users/olivier/.npm/_logs/2025-01-10T03_01_31_179Z-eresolve-report.txt                    │
│npm error A complete log of this run can be found in: /Users/olivier/.npm/_logs/2025-01-10T03_01_31_│
│179Z-debug-0.log                                                                                    │

In packages/app-desktop:
there is a dependency on "react": "18.3.1"
but also a devDependency on "@testing-library/react-hooks": "8.0.1", which itself declares a devDependency on "react": "17.0.2", and a peerDependency on "react": "^16.9.0 || ^17.0.0" (https://github.com/testing-library/react-hooks-testing-library/blob/main/package.json).

Hence the conflict.

The problem appears to be present at least all the way back to release-2.11.

Expected behaviour

No response

Logs

No response

@opichon opichon added the bug It's a bug label Jan 10, 2025
@personalizedrefrigerator
Copy link
Collaborator

running npm install on dev branch breaks with the following error message:

Be sure to use yarn to install dependencies — see BUILD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug
Projects
None yet
Development

No branches or pull requests

3 participants