Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too few arguments to function Berkayk\OneSignal\OneSignalClient::__construct(), 3 passed in S:\laravel\mygroceries\vendor\laravel-notification-channels\onesignal\src\OneSignalServiceProvider.php on line 25 and at least 4 expected #157

Open
afscf opened this issue Jan 21, 2025 · 2 comments
Open

Too few arguments to function Berkayk\OneSignal\OneSignalClient::__construct(), 3 passed in S:\laravel\mygroceries\vendor\laravel-notification-channels\onesignal\src\OneSignalServiceProvider.php on line 25 and at least 4 expected #157

afscf opened this issue Jan 21, 2025 · 2 comments

Comments

@afscf
Copy link

afscf commented Jan 21, 2025

I just installed the package like all the time and now i have this issue.
@GalahadXVI
Copy link

GalahadXVI commented Jan 24, 2025 •
edited
Loading

Encountering same issue after updating the packages

@GalahadXVI
Copy link

GalahadXVI commented Jan 24, 2025 •
edited
Loading

The issue is caused by this change:
berkayk/laravel-onesignal@v2.2...v2.3

which added an extra argument to the __construct( ) method.

This package will need updating so that it passes a $restApiUrl to the OneSignalClient.

As a temporary solution, just downgrade berkayk/laravel-onesignal to any version below v2.3
composer require berkayk/onesignal-laravel:2.2. This might break after March 1, 2025.

Related PR: #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GalahadXVI @afscf