Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inserts): resolve issues with undefined values #1311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(inserts): resolve issues with undefined values #1311

wants to merge 1 commit into from
+13 −10

Conversation

naorpeled
Copy link
Contributor

closes #1310

@vercel Vercel
Copy link

vercel bot commented Jan 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 8:06pm

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 5, 2025 •
edited
Loading

Open in Stackblitz • kysely_koa_example

npm i https://pkg.pr.new/kysely-org/kysely@1311

commit: bb1ed4b

@koskimas
Copy link
Member

koskimas commented Jan 6, 2025 •
edited
Loading

Looking good otheriwse but: when inserting a single row, the value should actually be missing and not DEFAULT. The change now caused DEFAULT being used even when you insert a single row with an undefined value (see all the failing tests).

Most databases support DEFAULT but not all. For example on sqlite we need to use null instead. Mapping undefined to null is not a good idea when it can be avoided.

@naorpeled
Copy link
Contributor Author

Looking good otheriwse but: when inserting a single row, the value should actually be missing and not DEFAULT. The change now caused DEFAULT being used even when you insert a single row with an undefined value (see all the failing tests).

Most databases support DEFAULT but not all. For example on sqlite we need to use null instead. Mapping undefined to null is not a good idea when it can be avoided.

Makes sense,
how would you separate those two cases in the cleanest way?

@koskimas
Copy link
Member

koskimas commented Jan 7, 2025

how would you separate those two cases in the cleanest way?

Don't know. Maybe just a special case when rows.length === 1? Add a comment why the special case is there in case you end up with this solution.

@naorpeled naorpeled force-pushed the fix/inserts/resolve-undefined-values-not-replacing-with-default branch from 6b7e19f to c22f2dd Compare January 9, 2025 20:04
@naorpeled naorpeled force-pushed the fix/inserts/resolve-undefined-values-not-replacing-with-default branch from c22f2dd to bb1ed4b Compare January 9, 2025 20:05
@naorpeled naorpeled marked this pull request as ready for review January 9, 2025 20:08
@naorpeled
Copy link
Contributor Author

@koskimas let me know what you think 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batch inserts use "undefined" instead of falling back on default value
2 participants
@naorpeled @koskimas