Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tide merges PR when retesting GitHub action #337

Open
saschagrunert opened this issue Dec 3, 2024 · 1 comment
Open

Tide merges PR when retesting GitHub action #337

saschagrunert opened this issue Dec 3, 2024 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@saschagrunert
Copy link
Member

saschagrunert commented Dec 3, 2024

It happens from time to time that tide merges a PR when re-triggering a GitHub action. This results in the following contextual situation:

screenshot

We can see that e2e-fedora has not passed but also not yet started. Example PR:

Tide still merged the PR, I assume because of a race like outlined in:

prow/pkg/tide/status.go

Lines 478 to 492 in f9126b3

// The list of all open PRs may not contain a PR if it was merged before we
// listed all open PRs. To prevent a new PR that starts in the pool and
// immediately merges from missing a tide status context we need to ensure that
// every PR in the pool is processed even if it doesn't appear in all.
//
// Note: We could still fail to update a status context if the statusController
// falls behind the main Tide sync loop by multiple loops (if we are lapped).
// This would be unlikely to occur, could only occur if the status update sync
// period is longer than the main sync period, and would only result in a
// missing tide status context on a successfully merged PR.
for key, poolPR := range pool {
if !processed.Has(key) {
process(&poolPR)
}
}

@saschagrunert
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants