Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate MachineController/OperatingSystemManager and cloudProvider None are mutually exclusive #3369

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Validate MachineController/OperatingSystemManager and cloudProvider None are mutually exclusive #3369

merged 1 commit into from
Jan 13, 2025
+39 −3

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Sep 13, 2024 •
edited by kubermatic-bot
Loading

Which issue(s) this PR fixes:

Fixes #3366

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

[ACTION REQUIRED] Disallow using machine-controller and operating-system-manager with the cloud provider `none` (`.cloudProvider.none`). If you're affected by this change, you have to either disable machine-controller and/or operating-system-manager, or switch from cloud provider none to a supported cloud provider. This affects both KubeOneCluster v1beta2 and v1beta3 APIs.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 13, 2024
@kron4eg kron4eg requested a review from xmudrii September 13, 2024 10:05
@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2024
@kubermatic-bot
Copy link
Contributor

@kron4eg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubeone-e2e-aws-default-install-containerd-external-v1.31.0 2918dda link true /test pull-kubeone-e2e-aws-default-install-containerd-external-v1.31.0

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

xmudrii
xmudrii requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in #3366 (comment), we shouldn't forbid this, but properly handle it

@kron4eg kron4eg closed this Oct 3, 2024
@kron4eg kron4eg deleted the mc-osm-cloudprovider-none-validation branch October 3, 2024 11:10
@kron4eg kron4eg restored the mc-osm-cloudprovider-none-validation branch January 13, 2025 01:14
@kron4eg kron4eg reopened this Jan 13, 2025
@kron4eg kron4eg marked this pull request as draft January 13, 2025 01:15
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@kron4eg
Validate MachineController/OperatingSystemManager and cloudProvider N…
27ebcec 
…one are mutually exclusive

Signed-off-by: Artiom Diomin <[email protected]>
@kron4eg kron4eg force-pushed the mc-osm-cloudprovider-none-validation branch from 2918dda to 27ebcec Compare January 13, 2025 01:15
@kron4eg
Copy link
Member Author

kron4eg commented Jan 13, 2025

Since we got #3416, this PR can be merge too.

@kron4eg kron4eg requested a review from xmudrii January 13, 2025 01:17
@xmudrii
Copy link
Member

xmudrii commented Jan 13, 2025

@kron4eg Yes, we can proceed if you want.

@kron4eg kron4eg marked this pull request as ready for review January 13, 2025 09:30
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
xmudrii
xmudrii approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5dc83d7859faab7b905265d18441906fd69e36d8

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
@xmudrii
Copy link
Member

xmudrii commented Jan 13, 2025

/remove-kind bug
/kind api-change
/release-note-edit

[ACTION REQUIRED] Disallow using machine-controller and operating-system-manager with the cloud provider `none` (`.cloudProvider.none`). If you're affected by this change, you have to either disable machine-controller and/or operating-system-manager, or switch from cloud provider none to a supported cloud provider. This affects both KubeOneCluster v1beta2 and v1beta3 APIs.

@kubermatic-bot kubermatic-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed kind/bug Categorizes issue or PR as related to a bug. labels Jan 13, 2025
@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 13, 2025
@kubermatic-bot kubermatic-bot merged commit 7b8d692 into kubermatic:main Jan 13, 2025
14 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.10 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.10
Development

Successfully merging this pull request may close these issues.

Validation permits having cloudProvider.none and machineController.deploy=true
3 participants
@kron4eg @kubermatic-bot @xmudrii